Skip to content

Commit

Permalink
[Dashboard] fix Export CSV doesnt work (elastic#198547)
Browse files Browse the repository at this point in the history
Closes elastic#198517

elastic#193644 refactored Dashboard
services. Part of this refactor moved `fieldFormats` from
`data.fieldFormats` to getting `fieldFormats` directly from the
fieldFormats plugin. That is because `data.fieldFormats` is marked as
deprecated. The problem is that the fieldFormats plugin was not defined
under `requiredPlugins` and thus was undefined at runtime.

### Test instructions
1) install web logs sample data
2) open web logs sample data dashboard
3) hover over "[Logs] Response Codes Over Time + Annotations" panel and
select "three dots" icon. Then select "Download CSV". Verify there are
no errors in web browser console and CSV is downloaded.
  • Loading branch information
nreese committed Nov 1, 2024
1 parent 56873fe commit 232c794
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/plugins/dashboard/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"dataViews",
"dataViewEditor",
"embeddable",
"fieldFormats",
"controls",
"inspector",
"navigation",
Expand Down

0 comments on commit 232c794

Please sign in to comment.