Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves changes to error handling in various test cases across multiple files, along with an update to the package version in
package.json
. The error handling changes involve replacing the previous method of catching specific errors with a more general error catch block, which then checks if the caught error is an instance of the expected error.Error handling changes:
test/basic-api-errors-test.js
: Modified error handling in the teststest transaction outside of session
,test atomic outside of session
,test getConnection after release
, andtest transaction after release
to use a general catch block and then check if the error is an instance ofdb.NoSessionAvailable
. [1] [2] [3] [4]test/basic-atomic-error-test.js
: Modified error handling in the teststest error in BEGIN
andtest error in COMMIT
to use a general catch block and then check if the error is an instance ofBeginError
orCommitError
respectively. [1] [2]test/basic-session-error-test.js
: Modified error handling in the testcannot connect
to use a general catch block and then check if the error is an instance ofTestError
.test/basic-transaction-error-test.js
: Modified error handling in the teststest error in BEGIN
andtest error in COMMIT
to use a general catch block and then check if the error is an instance ofBeginError
orCommitError
respectively. [1] [2]Package version update:
package.json
: Updated the package version from1.3.2
to1.4.2
.Ref: https://github.com/github/npm/issues/12234