fix!: honors ignoreScripts option to prevent prepare lifecycle script
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
force-pushed
the
reggi/ignore-scripts
branch
2 times, most recently
from
d215fb9
to
dc96529
Compare
reggi
changed the title
ignoreScripts to prevent prepare lifecycle
reggi
changed the title
ignoreScripts option to prevent prepare lifecycle script
…ript BREAKING CHANGE: honors `ignoreScripts` property within options
reggi
force-pushed
the
reggi/ignore-scripts
branch
from
dc96529
to
d8254e9
Compare
wraithgar
approved these changes
Oct 16, 2024
Merged
reggi
pushed a commit
that referenced
this pull request
Oct 17, 2024
🤖 I have created a release *beep* *boop* --- ## [20.0.0](v19.0.1...v20.0.0) (2024-10-17) ###⚠️ BREAKING CHANGES * honors `ignoreScripts` property within options ### Bug Fixes * [`f27af63`](f27af63) [#407](#407) honors `ignoreScripts` option to prevent `prepare` lifecycle script (@reggi) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ignoreScript option support to prevent execution of prepare lifecycle script.
from: npm/cli#7211
part of: npm/statusboard#898
Currently the tests don't run locally for some reason, i'm thinking because they spin up a https://localhost server. It runs in docker.
I used this to isolate the build and test locally: