fix: workspaces run at root #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't "support" running out of root, and there are other issues where we've said that the kinds of bugs folks have from doing so won't be fixed. Running from |
wraithgar
reviewed
Oct 9, 2024
| * it's not feasible to test the codepath where cwd is root `/` | ||
| * tap doesn't support it and an attempt with mock-fs broke nyc | ||
| */ | ||
| if (sep[0] === '') { |
There was a problem hiding this comment.
This will stream the leading slash off all globs, won't it?
wraithgar
reviewed
Oct 9, 2024
| @@ -125,7 +139,7 @@ async function mapWorkspaces (opts = {}) { | |||
| const orderedMatches = [] | |||
| for (const pattern of patterns) { | |||
| orderedMatches.push(...matches.filter((m) => { | |||
| return minimatch(m, pattern, { partial: true, windowsPathsNoEscape: true }) | |||
| return minimatch(removeRootPath(m), pattern, { partial: true, windowsPathsNoEscape: true }) | |||
There was a problem hiding this comment.
If we filter these out of the matches we don't have to call this new function. every time for every pattern.
A .map in line 135 seems appropriate, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into npm/cli#7563 where
npm run -w packages/workspacedoesn't work when the cwd is root / (docker issue).Turns out it's because this returns false here https://github.com/npm/map-workspaces/blob/main/lib/index.js#L128
I wish we could catch these. It is not possible to test this kind of code that uses cwd
/.