Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back complete favicon feature set #364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Brar
Copy link
Member

@Brar Brar commented Sep 21, 2024

With the recent docfx update we lost some advanced favicon features.
This brings them back and also updates them with regards to additional featuress.

@Brar Brar requested a review from roji September 21, 2024 07:46
@@ -37,7 +37,8 @@
"template":
[
"default",
"modern"
"modern",
"template"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this npgsql_template to make it clearer it's our customizations etc.

@@ -0,0 +1,46 @@
{{!Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.}}

<head>
Copy link
Member

@roji roji Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this override means we need to react if there are any upstream changes in the modern template... This is what caused things when I was upgrading things, which is why I removed it.

I'm hoping maybe there's some way to just add our favicons rather than replacing the entire <head>, which seems like it could cause similar trouble in the future... Is something like that possible, like some more targeted partial or extensibility hook specifically for favicon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping maybe there's some way to just add our favicons rather than replacing the entire

Not out of the box. That would be an upstream PR to docfx.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

Yeah, good favicon support could be a nice thing to contribute to the upstream template, if you feel like doing that kind of work! Otherwise OK to merge for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants