Docs related to version 7 GUID generation #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2024
Original commit: 2322a1a
Timovzl
reviewed
Sep 3, 2024
| @@ -92,17 +92,17 @@ protected override void OnModelCreating(ModelBuilder modelBuilder) | |||
|
|
|||
| ## GUID/UUID Generation | |||
|
|
|||
| By default, for GUID key properties, a random GUID is generated client-side by the EF provider and sent to the database. | |||
| By default, for GUID key properties, a GUID is generated client-side by the EF provider and sent to the database. From version 9.0 and onwards, these GUIDs are sequential (version 7), which are more optimized for database indexes (before version 9.0, these GUIDs were random). | |||
There was a problem hiding this comment.
Suggestion: Consider emphasis on the word key.
I personally read over this without much realization, until I read the next paragraph.
Timovzl
reviewed
Sep 3, 2024
|
|
||
| When your entity types have a `Guid` key, EF Core by default generates key values for new entities client-side - in .NET - before inserting those entity types to the database; this can be better for performance in some situations. Before version 9.0, the provider generated random GUIDs (version 4) by calling the .NET [`Guid.NewGuid()`](https://learn.microsoft.com/en-us/dotnet/api/system.guid.newguid?view=net-8.0#system-guid-newguid) function. Unfortunately, random GUIDs aren't ideal for database indexing and can cause performance issues. | ||
|
|
||
| Version 9.0 of the provider now generates the recently standardized version 7 GUIDs, which is a sequential GUID type that's more appropriate for database indexes and improves their performance. This new behavior is by default and will take effect simply by upgrading the provider version. |
There was a problem hiding this comment.
Typo: Was "this new behavior is by default" intended to read "this new behavior is on/enabled by default"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See npgsql/efcore.pg#3249
/cc @ChrisJollyAU @Timovzl, here are some docs on the UUIDv7 change - let me know if you have any feedback!