Redo JSON documentation #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
Original commit: ab1dd88
vonzshik
reviewed
Nov 19, 2023
|
|
||
| ### [Global mapping](#tab/global) | ||
|
|
||
| If you're using an older version of Npgsql which doesn't yet support `NpgsqlDataSource`, you can configure mappings globally for all connections in your application: |
There was a problem hiding this comment.
Isn't that only required starting with 8.0, as 7.0 and 6.0 can just send them as is?
There was a problem hiding this comment.
There's a note above: "Startin with Npgsql 8.0, to use this feature, you must fir eanble it by calling..." (typo with Startin...). Do you think that's not enough?
There was a problem hiding this comment.
I don't understand what's the point of this sentence:
If you're using an older version of Npgsql which doesn't yet support `NpgsqlDataSource`, you can configure mappings globally for all connections in your application:
given that you don't actually have to do anything
There was a problem hiding this comment.
Ah I see, OK - will remove it.
There was a problem hiding this comment.
Or rather tweak it - there are people using Npgsql 8.0 but who are still not using NpgsqlDataSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vonzshik @NinoFloris @Brar would be good to get some eyes on this (but I'll go ahead and merge, we can always correct later).
Closes #217
/cc @ajcvickers