Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integrations): API #39

Merged
merged 4 commits into from
Oct 29, 2023
Merged

feat(integrations): API #39

merged 4 commits into from
Oct 29, 2023

Conversation

king-11
Copy link
Contributor

@king-11 king-11 commented Oct 29, 2023

Fixes #9

  • update channel type enum
  • add integration structs
  • add integration methods

@king-11 king-11 changed the title Integrations Integrations Module Oct 29, 2023
@king-11
chore: format code
ac3a6f4 
Signed-off-by: Lakshya Singh <[email protected]>
@jainpawan21
Copy link
Member

@kymppi could you please help us in reviewing this PR?

@kymppi kymppi changed the title Integrations Module feat(integrations): API Oct 29, 2023
@kymppi kymppi merged commit ee6aa09 into novuhq:master Oct 29, 2023
5 checks passed
@king-11 king-11 deleted the integrations branch October 29, 2023 17:31
@king-11
Copy link
Contributor Author

king-11 commented Oct 29, 2023

made a slight mistake in hindsight, didn't rename the step_filter_type to type sending a PR for the same

@king-11
Copy link
Contributor Author

king-11 commented Oct 29, 2023

@kymppi can you please check #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kymppi kymppi kymppi approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Missing Methods for Integrations
4 participants
@king-11 @jainpawan21 @kymppi @Cliftonz