Removing unnecessary dev comments

novuhq · Oct 7, 2023 · f999d73 · f999d73
1 parent 29c2cb0
commit f999d73
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 30 deletions.
diff --git a/src/client.rs b/src/client.rs
@@ -49,7 +49,6 @@ impl Client {
     pub async fn post<T: DeserializeOwned>(
         &self,
         endpoint: impl ToString,
-        //optional data, prevent serialization error. this currently fails if data is not provided or () is provided
         data: Option<&impl Serialize>,
     ) -> Result<Response<T>, NovuError> {
         if data.is_none() {

diff --git a/src/environments.rs b/src/environments.rs
@@ -1,22 +1,5 @@
 use serde::{Deserialize, Serialize};
 
-/** Environment api response
- * {
-  "data": {
-    "_id": "string",
-    "name": "string",
-    "_organizationId": "string",
-    "identifier": "string",
-    "apiKeys": [
-      {
-        "key": "string",
-        "_userId": "string"
-      }
-    ],
-    "_parentId": "string"
-  }
-}
- */
 #[derive(Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct Environment {
@@ -42,17 +25,6 @@ pub struct EnvironmentPayload {
     pub parent_id: Option<String>,
 }
 
-/*
-{
-    'name' => 'Local', # optional
-    'identifier' => 'local', # optional
-    'parentId' => '7789', # optional
-    'dns' => { # optional
-        'inboundParseDomain' => 'dev.test' # optional
-    }
-}
-
-*/
 #[derive(Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct CreateEnvironmentPayload {

diff --git a/src/lib.rs b/src/lib.rs
@@ -113,7 +113,7 @@ impl Novu {
     pub async fn update_environment(
         &self,
         environment_id: String,
-        data: CreateEnvironmentPayload, // this is flattened, fix
+        data: CreateEnvironmentPayload,
     ) -> Result<Environment, NovuError> {
         let result = self
             .client