Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helpers build_messages_attributes #243

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Add Helpers build_messages_attributes #243

merged 8 commits into from
Sep 26, 2024

Conversation

khayomacedo
Copy link
Contributor

Contain

  • New feature
  • Tests

Details

  • Add Modules Helpers containing the build_messages_attributes function, which is responsible for standardizing and handling message attributes sent to Pub/Sub.
  • Add unittest to cover following scenarios, (Empty attributes, String attributes, Numeric attributes (int and fload), combination os string and number, and handling unsupported types (raises TypeError).

julianolf
julianolf reviewed Sep 25, 2024
View reviewed changes
faster_sam/dependencies/events.py Outdated Show resolved Hide resolved
faster_sam/dependencies/helpers.py Outdated Show resolved Hide resolved
faster_sam/dependencies/helpers.py Outdated Show resolved Hide resolved
faster_sam/dependencies/helpers.py Outdated Show resolved Hide resolved
faster_sam/dependencies/helpers.py Outdated Show resolved Hide resolved
tests/test_helpers.py Outdated Show resolved Hide resolved
tests/test_helpers.py Show resolved Hide resolved
@julianolf julianolf added the enhancement New feature or request label Sep 26, 2024
@julianolf julianolf merged commit cbcd45f into noverde:main Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianolf julianolf julianolf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khayomacedo @julianolf