Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android for release flow according issue discussion #2319

Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix: android for release flow according issue discussion #2319

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e23dde5
fix for release flow according issue discussion
Dmitry-Borodin Jan 31, 2024
dafac2c
removed extra line
Dmitry-Borodin Jan 31, 2024
8228077
hardcoded build tools to 34
Dmitry-Borodin Jan 31, 2024
bc4759e
created extra step to find out latest built tools for signing apk
Dmitry-Borodin Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/android-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ jobs:
run: |
./gradlew clean assembleRelease --stacktrace

- name: Setup build tool version variable
shell: bash
run: |
BUILD_TOOL_VERSION=$(ls /usr/local/lib/android/sdk/build-tools/ | tail -n 1)
echo "BUILD_TOOL_VERSION=$BUILD_TOOL_VERSION" >> $GITHUB_ENV
echo Last build tool version is: $BUILD_TOOL_VERSION

- name: Sign app APK
uses: r0adkll/sign-android-release@v1
# ID used to access action output
Expand All @@ -139,6 +146,8 @@ jobs:
alias: ${{ secrets.ANDROID_KEYSTORE_KEY_ALIAS }}
keyStorePassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }}
keyPassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }}
env:
BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }}

- name: Upload Gplay release APKs
uses: actions/upload-artifact@v3
Expand All @@ -156,4 +165,3 @@ jobs:
track: internal



Loading