Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: iOS dot identicon spm #1979

Merged
merged 11 commits into from
Aug 2, 2023
Merged

feat: iOS dot identicon spm #1979

merged 11 commits into from
Aug 2, 2023

Conversation

krodak
Copy link
Contributor

@krodak krodak commented Aug 1, 2023 •
edited
Loading

Purpose

Resolves #1953

Scope

Polkadot Identicon SPM adds ability to:

  • generate dot Identicon from base58 address
  • generate dot Identicon from hex address
  • generate dot Identicon from [UInt8] data
  • generating properly scalable UIImage, instead of pixel-by-pixel image in opposite to Rust library
  • SwiftUI class wrapper for ease of use

Screenshots

Dot identicon Rust library iOS

@krodak krodak self-assigned this Aug 1, 2023
@krodak krodak added the ios label Aug 1, 2023
@Dmitry-Borodin Dmitry-Borodin mentioned this pull request Aug 1, 2023
Closed
@krodak krodak marked this pull request as ready for review August 2, 2023 14:47
@prybalko prybalko merged commit 56e9c21 into master Aug 2, 2023
12 checks passed
@prybalko prybalko deleted the ios-dot-identicon-spm branch August 2, 2023 15:13
krodak added a commit that referenced this pull request Aug 3, 2023
@krodak
Merge branch 'master' into export-keys-v2
32a2ccd 
* master:
  chore(deps): bump Swatinem/rust-cache from 2.5.1 to 2.6.0 (#1983)
  chore(deps): bump indicatif from 0.17.5 to 0.17.6 in /rust (#1984)
  chore(deps): bump time from 0.3.24 to 0.3.25 in /rust (#1985)
  feat: Android dynamic derivations support (#1943)
  feat: iOS dot identicon spm (#1979)
  chore(deps): bump android_logger from 0.13.1 to 0.13.3 in /rust (#1981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prybalko prybalko prybalko approved these changes

@tetekinandrey tetekinandrey Awaiting requested review from tetekinandrey

@Dmitry-Borodin Dmitry-Borodin Awaiting requested review from Dmitry-Borodin

Assignees

@krodak krodak

Labels
ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle dot identicons rendering on iOS
2 participants
@krodak @prybalko