Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sign dd transactions #1978

Merged
merged 13 commits into from
Aug 9, 2023
Merged

feat: sign dd transactions #1978

merged 13 commits into from
Aug 9, 2023

Conversation

prybalko
Copy link
Contributor

@prybalko prybalko commented Jul 31, 2023 •
edited
Loading

Purpose

Fixes #1883
Support transactions with dynamically derived accounts.

For mobile developers

  • Call qrparser_try_decode_qr_sequence
  • New DynamicDerivationTransaction type is returned
  • Call sign_dd_transaction with the received payload

Test data

Test seed phrase: bottom drive obey lake curtain smoke basket hold race lonely fit walk

qrcode

@Dmitry-Borodin Dmitry-Borodin mentioned this pull request Aug 4, 2023
Closed
@prybalko prybalko marked this pull request as ready for review August 9, 2023 14:32
@prybalko prybalko merged commit ae6be95 into master Aug 9, 2023
10 checks passed
@prybalko prybalko deleted the sign-dd-transactions branch August 9, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmitry-Borodin Dmitry-Borodin Dmitry-Borodin approved these changes

@krodak krodak Awaiting requested review from krodak krodak is a code owner

@tetekinandrey tetekinandrey Awaiting requested review from tetekinandrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign dynamic derivation transactions
3 participants
@prybalko @Dmitry-Borodin @krodak