-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export keys v2 #1911
Merged
Merged
feat: export keys v2 #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: chore(deps): bump Swatinem/rust-cache from 2.5.1 to 2.6.0 (#1983) chore(deps): bump indicatif from 0.17.5 to 0.17.6 in /rust (#1984) chore(deps): bump time from 0.3.24 to 0.3.25 in /rust (#1985) feat: Android dynamic derivations support (#1943) feat: iOS dot identicon spm (#1979) chore(deps): bump android_logger from 0.13.1 to 0.13.3 in /rust (#1981)
Dmitry-Borodin
approved these changes
Aug 9, 2023
android adopted new api and requirements above. But new UI - selecting keys as bottom sheet is not implemented yet. Feel free to merge - I can update it as separate PR, it's isolated UI changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Scope
ExportAddrsV2
export_key_info
arguments to take only one seed nameToDo:
Export Key Set
menu from the main screen (debatable)Screenshot
Screenshot
cc: @krodak @Dmitry-Borodin