Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export keys v2 #1911

Merged
merged 11 commits into from
Aug 9, 2023
Merged

feat: export keys v2 #1911

merged 11 commits into from
Aug 9, 2023

Conversation

prybalko
Copy link
Contributor

@prybalko prybalko commented Jun 26, 2023

Purpose

  • Update key_set export format to include supported features
  • Export only 1 key set at a time.

Scope

  • Add ExportAddrsV2
  • alter export_key_info arguments to take only one seed name

ToDo:

  • Remove Export Key Set menu from the main screen (debatable)
Screenshot

IMG_0067

  • Allow to export 0 keys (only root public key will be exported)
Screenshot

IMG_0068

cc: @krodak @Dmitry-Borodin

@prybalko prybalko marked this pull request as ready for review August 2, 2023 13:21
* master:
  chore(deps): bump Swatinem/rust-cache from 2.5.1 to 2.6.0 (#1983)
  chore(deps): bump indicatif from 0.17.5 to 0.17.6 in /rust (#1984)
  chore(deps): bump time from 0.3.24 to 0.3.25 in /rust (#1985)
  feat: Android dynamic derivations support (#1943)
  feat: iOS dot identicon spm (#1979)
  chore(deps): bump android_logger from 0.13.1 to 0.13.3 in /rust (#1981)
@Dmitry-Borodin
Copy link
Contributor

android adopted new api and requirements above. But new UI - selecting keys as bottom sheet is not implemented yet. Feel free to merge - I can update it as separate PR, it's isolated UI changes.

@prybalko prybalko merged commit 5f8d9b8 into master Aug 9, 2023
10 checks passed
@prybalko prybalko deleted the export-keys-v2 branch August 9, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants