Skip to content

Commit

Permalink
feat: Android enabled dd and release (#2239)
Browse files Browse the repository at this point in the history
* feat: enable dynamic derivations in production

* feat: new release with dynamic derivations enabled 6.3.0
  • Loading branch information
Dmitry-Borodin authored Dec 22, 2023
1 parent b773f9c commit 250f163
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 26 deletions.
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ android {
applicationId "io.parity.signer"
minSdk 23
targetSdk 34
versionCode 60200
versionName "6.2.0"
versionCode 60300
versionName "6.3.0"
ndk {
abiFilters 'armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64'
}
Expand Down
2 changes: 0 additions & 2 deletions android/src/main/java/io/parity/signer/domain/FeatureFlags.kt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ object FeatureFlags {
FeatureOption.SKIP_UNLOCK_FOR_DEVELOPMENT -> false
FeatureOption.SKIP_ROOTED_CHECK_EMULATOR -> false
FeatureOption.EXPORT_SECRET_KEY -> false //unused
FeatureOption.ENABLE_DYNAMIC_DERIVATIONS -> true // enable for debug only
FeatureOption.FAIL_DB_VERSION_CHECK -> false

}
Expand All @@ -23,7 +22,6 @@ object FeatureFlags {

enum class FeatureOption {
FAIL_DB_VERSION_CHECK,
ENABLE_DYNAMIC_DERIVATIONS,
SKIP_UNLOCK_FOR_DEVELOPMENT,
SKIP_ROOTED_CHECK_EMULATOR,
EXPORT_SECRET_KEY; //unused as sample
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,31 +139,13 @@ class CameraViewModel() : ViewModel() {
}

is DecodeSequenceResult.DynamicDerivations -> {
if (FeatureFlags.isEnabled(FeatureOption.ENABLE_DYNAMIC_DERIVATIONS)) {
resetScanValues()
_dynamicDerivationPayload.value = payload.s
} else {
val context = ServiceLocator.appContext
Toast.makeText(
context,
"Dynamic derivations not supported yet",
Toast.LENGTH_LONG
).show()
}
resetScanValues()
_dynamicDerivationPayload.value = payload.s
}

is DecodeSequenceResult.DynamicDerivationTransaction -> {
if (FeatureFlags.isEnabled(FeatureOption.ENABLE_DYNAMIC_DERIVATIONS)) {
resetScanValues()
_dynamicDerivationTransactionPayload.value = payload.s
} else {
val context = ServiceLocator.appContext
Toast.makeText(
context,
"Dynamic derivations not supported yet",
Toast.LENGTH_LONG
).show()
}
resetScanValues()
_dynamicDerivationTransactionPayload.value = payload.s
}
}

Expand Down

0 comments on commit 250f163

Please sign in to comment.