DApp bottom sheet entry point #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentunn
reviewed
Nov 27, 2024
| import io.novafoundation.nova.core_db.dao.BrowserTabsDao | ||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| class TabsRepository(private val tabsDao: BrowserTabsDao) { |
There was a problem hiding this comment.
This should have an interface in dapp browser api and implementation in dapp browser impl and be provided to root
| import android.view.View | ||
| import android.view.ViewOutlineProvider | ||
|
|
||
| class RoundCornersOutlineProvider( |
| } | ||
|
|
||
| dappEntryPoint.isVisible = it > 0 | ||
| dappEntryPointText.text = getString(R.string.dapp_entry_point_title, it) |
There was a problem hiding this comment.
Shouldnt we display a proper tab name in case there's only one tab?
AlsoI think this formatting logic can go to ViewModel (whether to make entryPointVisible, what text to set to entry point)
| class Tab(val id: String) : DAppBrowserPayload | ||
|
|
||
| @Parcelize | ||
| class Address(val address: String) : DAppBrowserPayload |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8696nvaej
