Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ignore path for pr tests #1347

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Conversation

stepanLav
Copy link
Member

@stepanLav stepanLav commented Dec 28, 2023

That PR:

  • separate lint run and unit test run in order to start testing early (previous it runs only after linting)
  • Fail run if coverage lover than 50%, setup in jest.config file, current is:
coverageThreshold: {
    global: {
      branches: 50,
      functions: 50,
      lines: 50,
      statements: 50,
    },
  },
  • Added to exclude path for tests:
    '/src/renderer/entities/./ui',
    '/src/renderer/features/.
    /ui',
    '/tests/',

Tested by:
failed - https://github.com/novasamatech/nova-spektr/actions/runs/7347678612/job/20004505820?pr=1347
Screenshot 2023-12-28 at 15 41 03

success - https://github.com/novasamatech/nova-spektr/actions/runs/7347590966/job/20004275829
Screenshot 2023-12-28 at 15 40 41

Can't merge on failure:
Screenshot 2023-12-28 at 15 42 00

Copy link
Contributor

github-actions bot commented Dec 28, 2023

Jest Unit tests results

Generic badge

Duration: 75.401 seconds
Start: 2023-12-28 12:48:20.700 UTC
Finish: 2023-12-28 12:49:36.101 UTC
Duration: 75.401 seconds
Outcome: Passed | Total Tests: 395 | Passed: 393 | Failed: 0
Total Test Suites: 134
Total Tests: 395
Failed Test Suites: 0
Failed Tests: 0
Passed Test Suites: 133
Passed Tests: 393
Pending Test Suites: 1
Pending Tests: 2

@stepanLav stepanLav force-pushed the feat/coverage_improvements branch 2 times, most recently from 37bee1d to 4c73ee8 Compare December 28, 2023 12:42
@novasamatech novasamatech deleted a comment from github-actions bot Dec 28, 2023
@stepanLav stepanLav merged commit db57bd6 into dev Dec 29, 2023
4 checks passed
@stepanLav stepanLav deleted the feat/coverage_improvements branch December 29, 2023 09:35
stepanLav added a commit that referenced this pull request Feb 29, 2024
* fix: reject reason for rejector (#1340)

* feat: proxy service (#1278)

* feat: update libs, update effector tests to v23

* Feat: Another FSD iteration (#1331)

* Feat: notifications update (#1324)

* Feat: updated accordion styles (#1335)

* feat: updated accordion styles

* chore: removed some unused icons

---------

Co-authored-by: Egor B <[email protected]>

* fix: network update (#1346)

* feat: adding ignore path for pr tests (#1347)

* feat: adding ignore path for pr tests

* fix: devide lint and tests

* fix: name for workflows

* fix: lint

* fix: remove comment

* ci: chains.json file

* fix: return format back

* fix: return proxy settings back

* fix: file format

* ci: bump version

* fix: bifrost polkadot fix fee

* fix: bifrost xcm types  (#1353)

* fix: use dynamic xcm types for versions

* chore: fix comments

* ci: chains.json file (#1358)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* feat: add proxied wallets (#1344)

* Feat: wallet menu update (#1348)

* feat: [wip] wallet menu update

* feat: block parent scroll when popover is open

* chore: pr comments fix

* chore: imports fix

* chore: linter error fix

* Feat: UI imports (#1360)

* feat: ui imports & branch coverage

* chore: i18n update

---------

Co-authored-by: Egor B <[email protected]>
Co-authored-by: Yaroslav Grachev <[email protected]>

* Adding system tests (#1086)

* feat: add first test

* feat: change to pageObject

* feat: rewrite on playwright

* feat: rewrite on playwright

* feat: add more cases

* feat: matrix login test

* fix: dockercompose files

* chore: fix package.json

* chore: fix package.json

* chore: resolve conflicts

* fix: linter problems

* fix: add info and remove redundant browsers

* fix: increase matrix timeout

* feat: add matrix login in multisig creation flow

* fix: improve tests for matrix auth

* fix: comments

* fix: update to current dev

* chore: clean up code

fix: readme

* feat: adding publication

* fix: increase timeout

* feat: save many reports

* fix: url

* fix: set only for main branch

* Feat: Notifications (#1357)

* feat: useUnit (#1368)

* feat: exclude proxied wallet from multisig creation (#1369)

* feat: use ExplorerPopover (#1362)

* chore: remove unused component (#1370)

* ci: chains.json file (#1366)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix: Close wallet manage (#1367)

* Fix: Delelegated wallet name (#1364)

* feat: update proxy accounts and deposits (#1363)

* fix: remove workfround (#1372)

* fix: not create proxied account with non-zero delay (#1371)

* Feat: Proxied wallet details (#1365)

* feat: added proxy accounts to wallet details

* chore: added sorting for proxy accounts

* chore: sorted locale file

* chore: linter error fix

* feat: update proxy accounts and deposits

* chore: revert code for refactoring

* chore: fix deposits calc

* chore: fix deposit calc

* chore: update tests

* chore: add ts ignore

* chore: disable global assign validation in test

* chore: fix tests

* chore: update tests

* chore: update tests

* chore: update tests

* chore: update tests

* feat: updated proxy chain groups

* chore: updated explorers popup styles

* feat: proxied wallet details

* feat: added proxies tab to proxied wallet details

* chore: fix eslint disable

* chore: sorted linter keys

* chore: fixed pr comments

* chore: imports fix

* chore: moved proxy account action to separate components

* chore: changed chainServie to networkModel for wallet connect accounts

* chore: fixed proxy list after merge

* chore: shorten inputs

* chore: pr comments fix

* chore: added test for proxy sort

* chore: added tests for wallet-provider-model

* chore: updated tests

* chore: pr comments fix

* chore: sorted locale file

* chore: updated wallet details heights

---------

Co-authored-by: Egor B <[email protected]>
Co-authored-by: asmadek <[email protected]>

* fix: avoid create proxieds for watch only (#1373)

* fix: add proxy groups (#1374)

* Fix: proxy deposit in proxies list (#1375)

* fix: proxy deposit in proxies list

* chore: uncomment logs

* chore: delete comment

---------

Co-authored-by: Egor B <[email protected]>

* fix: add/remove proxies (#1379)

* fix: proxy description (#1381)

* fix: proxy description

* fix: lint

* feat: add more logs for proxy-worker (#1377)

* feat: add more logs for proxy-worker

* fix: format

* fix: toString

* fix: add proxies to remove

* fix: adding genesis to each network

* fix: merge conflicts

* fix: emoji

* fix:  proxy creation through db (#1385)

* fix: remove proxies (#1386)

* fix: popover styles (#1376)

* Feat: Network upgrade (#1378)

* fix: proxies in details (#1387)

* feat: decode proxy transactions (#1380)

* Feat: Remove proxy (#1382)

* feat: [wip] proxy removal

* fix: add/remove proxies

* chore: fix comments

* feat: remove proxy submit

* chore: added remove-proxy model and tests

* chore: modal title style fix

* chore: uncommented logs

* chore: localisation fix

* fix: update deposit after proxy removal

* chore: pr comments fix

* chore: pr comments fix

* chore: moved ProxyNames to constants

* chore: moved remove proxy modal to proxy list

* fix: proxy model error fix

* chore: remove proxiedAccountId key from ProxyStore when all proxies deleted

* chore: updated wallet provider test

* chore: fix typo

---------

Co-authored-by: Egor B <[email protected]>
Co-authored-by: asmadek <[email protected]>

* Fix: proxy group not created for delegated wallets (#1388)

* fix: run proxy group creation again after proxied wallet added

* chore: moved proxied wallet creation to proxies model

* chore: updatet hasProxies condition to check for proxy groups

* chore: removed proxiedWalletAdded test from wallet-model

* chore: pr comments fix

---------

Co-authored-by: Egor B <[email protected]>

* chore: transferKeepAlive instead of allowDeath

* fix: Update src/renderer/app/index.tsx

* fix: notifications sort (#1399)

* fix: keep logger

* fix: name wrapping (#1400)

* fix: don't switch to assets after add proxied (#1394)

* fix: show assets for available chains (#1393)

* Fix: Light Client connect (#1391)

* Fix: proxyType name fix for remove proxy confirmation screen (#1402)

* fix: run proxy group creation again after proxied wallet added

* chore: moved proxied wallet creation to proxies model

* chore: updatet hasProxies condition to check for proxy groups

* chore: removed proxiedWalletAdded test from wallet-model

* chore: pr comments fix

* fix: proxyType name fix for remove proxy confirmation screen

* chore: moved split camel case code to utils

* chore: change param desc

* chore: updated getProxyTypeName func and added tests

* chore: removed comment

---------

Co-authored-by: Egor B <[email protected]>

* fix: update wallet icons (#1405)

* Fix: remove proxy pending state (#1416)

* fix: hide zero balance by default & tests (#1406)

* Fix: Duplicated proxies (#1392)

* feat: permission service (#1390)

* fix: remove staking and governance from default proxy keys (#1417)

* fix: changed canCreateProxy store (#1418)

* Fix: Multisig creation warning (#1389)

* fix: ci label (#1426)

* fix: create multisig signatories list overflow (#1423)

Co-authored-by: Egor B <[email protected]>

* Fix: updated empty state tabs style for wc details (#1422)

* fix: updated empty state tabs style for wc details

* chore: linter error fix

---------

Co-authored-by: Egor B <[email protected]>

* Feat: remove delegated wallets on wallet forget (#1403)

* feat: remove delegated wallets on wallet forget

* chore: removed unused mock

* chore: removed unused import

* chore: pr comments fix

* chore: updated forget wallet model

* chore: linter error fix

* chore: pr comments fix

---------

Co-authored-by: Egor B <[email protected]>

* fix: allow unkown wallet type

* fix: stray log

* fix: typo

* feat: update feedback and bug report templates (#1446)

* feat: support proxy txs in operations

* fix: use new icon for transfer confirm

* fix: use new confirm icon for staking operations

* fix: reject multisig transaction button

* chore: fix i18n

* chore: update tests

* chore: fix comments

* chore: fix tests

* Feedback processing (#1425)

* ci: upgrade package.json

* ci: chains.json file (#1427)

change specName
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: remove focus from info (#1421)

* Fix: jdenticon for PV root (#1419)

* Fix: create only default chain accounts for vault wallet (#1424)

* fix: remove staking for polkadex/ternoa (#1430)

* Fix: Add main key type to key type dropdon for DD (#1438)

* Fix: updated unique derivation path validation (#1437)

* fix: connect to ws in worker (#1450)

* fix: connect to ws in worker

* chore: some refactoring

* Feat: single chain multisig account (#1448)

* Feat: Matrix SSO (#1447)

* fix: matrix modal on multisig (#1457)

* fix: remove tzero price id (#1458)

* fix: single chain multisig feedback (#1466)

* fix: correct room creation (#1467)

* fix: exclude wow accounts from multisig creation (#1469)

* fix: use net.fetch to get auto content-type (#1471)

* Fix: Duplicated SSO login  (#1470)

* Fix: Revert scheme (#1482)

* fix: merge conflicts  (#1486)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yaroslav Grachev <[email protected]>
Co-authored-by: Aleksandr Makhnev <[email protected]>
Co-authored-by: egor0798 <[email protected]>

* fix: disable chain selector on confirm step

* fix: localhost scheme (#1492)

* feat: create accounts in evm chains

* chore: fix tests

* fix: singleshard account creation

* fix: signatories for multisig

* chore: fix comments

* chore: fix comments

* fix: matrix room create condition (#1503)

fix: comment

* fix: nova wallet icon

* fix: more common solution for nova wallet icon

* fix: accounts list on select signatories
fix: back button for multisig creation

* fix: correct crypto type for single shard

* fix: disallow sharded for KeyType.Main (#1512)

* fix: add optional for wallet accounts on multisig creation

* chore: add todo

* ci: update version in package.json

* fix: remove proxy from config (#1519)

* fix: remove proxies tab on wallet details

* fix: explorers button on log

* fix: update chains file

---------

Co-authored-by: Aleksandr Makhnev <[email protected]>
Co-authored-by: Yaroslav Grachev <[email protected]>
Co-authored-by: egor0798 <[email protected]>
Co-authored-by: Egor B <[email protected]>
Co-authored-by: Stepan Lavrentev <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stepan Lavrentev <[email protected]>
Co-authored-by: Pavel <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Thibaut Sardan <[email protected]>
Co-authored-by: Aleksandr Makhnev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants