Feat: Price provider model #1084

tuul-wq · 2023-09-20T08:10:23Z

Price provider model
Fiat service
Currency model

# Conflicts: # src/renderer/app/index.tsx

github-actions · 2023-09-20T08:11:25Z

Current coverage report

Summary

Lines	Statements	Branches	Functions
	87.3% (165/189)	64.28% (9/14)	89.58% (43/48)

Tests which was executed

Tests	Skipped	Failures	Errors	Time
235	0 💤	0 ❌	0 🔥	3m 8s ⏱️

Coverage by files (86%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	87.3	64.28	89.58	86.66
app	0	0	0	0
App.tsx	0	0	0	0	20–51
entities/price/lib	100	100	100	100
constants.ts	100	100	100	100
types.ts	100	100	100	100
entities/price/model	100	100	100	100
currency-model.ts	100	100	100	100
price-provider-model.ts	100	100	100	100
shared/api/local-storage	100	100	100	100
index.ts	100	100	100	100
shared/api/local-storage/service	80	66.66	100	75
localStorageService.ts	80	66.66	100	75	14–16
shared/api/price-provider	100	100	100	100
index.ts	100	100	100	100
shared/api/price-provider/common	100	100	100	100
constants.ts	100	100	100	100
utils.ts	100	100	100	100
shared/api/price-provider/service	100	100	100	100
coingeckoService.ts	100	100	100	100
fiatService.ts	100	100	100	100
shared/core	100	100	100	100
index.ts	100	100	100	100
shared/core/model	100	100	100	100
kernel-model.ts	100	100	100	100

tuul-wq · 2023-09-20T08:11:28Z

src/renderer/app/App.tsx

@@ -22,6 +24,10 @@ const App = () => {
  const appRoutes = useRoutes(routesConfig);
  const { getAccounts } = useAccount();

+  const [assetsPrices, activeCurrency] = useUnit([priceProviderModel.$assetsPrices, currencyModel.$activeCurrency]);


This is added temporary, to make effector model work you need to import it somewhere.
Can be deleted after Egor's PR

tuul-wq · 2023-09-20T08:19:20Z

Task linked: CU-866avwp8j Create fiat values data structure and service

github-actions · 2023-09-20T08:19:29Z

Jest Unit tests results

Duration: 239.212 seconds

Start:	`2023-09-21 06:15:37.860 UTC`
Finish:	`2023-09-21 06:19:37.072 UTC`
Duration:	`239.212 seconds`

Outcome: Passed | Total Tests: 356 | Passed: 356 | Failed: 0

Total Test Suites:	144
Total Tests:	356
Failed Test Suites:	0
Failed Tests:	0
Passed Test Suites:	144
Passed Tests:	356

src/renderer/shared/api/price-provider/common/constants.ts

src/renderer/shared/api/price-provider/service/fiatService.ts

src/renderer/entities/price/model/currency-model.ts

src/renderer/shared/api/price-provider/service/fiatService.ts

src/renderer/entities/price/model/price-provider-model.ts

* Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * feat: added fiat amount for transfer and multisig operations * feat: added fiat values to staking operations --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]>

* Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * Feat: wallet fiat balance balance (#1099) * Feat: Operations parameters fiat amount (#1098) * Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * feat: added fiat amount for transfer and multisig operations * feat: added fiat values to staking operations --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]> * Feat: Fiat update rules (#1096) * feat: fiat update rules * chore: added test * Update src/renderer/entities/price/model/__tests__/price-provider-model.test.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: updated price proveder test * chore: improved priceProvider test --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * Feat/adding dev build (#1103) * Feat: Transaction service refactoring (#1053) * feat: added new transaction service, extrinsic builder and changed transfer florw * feat: removed extra components, changed get fee func * fix: wrap tx for submit step only if account is multisig * feat: implemented new service usage for staking transactions * fix: fix build tx error * chore: fixed tests, removed extrinsic service from public api * fix: signatory error fix * chore: renamed wrappers * chore: renamed operation footer prop and make it optional * Update src/renderer/entities/transaction/lib/extrinsicService.ts Co-authored-by: Yaroslav Grachev <[email protected]> * Update src/renderer/entities/multisig/lib/multisigTx/common/utils.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: fixed pr comments * chore: fixed linter error * chore: removed extra props from transfer form * chore: fix lockfile * chore: fixed confirmation test * fix: fixed xcm transfer fee error * fix: fixed amount error * chore: fixed invalid character error --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * feat: add stage build * fix: remove config separation * fix: change triggers * fix: github triggers * fix: change approach to url management * fix: change trigger and github command * fix: add separate webpack for internal build * fix: eslinter * fix: typo in yamls * Update src/main/factories/create.ts Co-authored-by: Aleksandr Makhnev <[email protected]> --------- Co-authored-by: egor0798 <[email protected]> Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> * Fix: Currency form value reset on close (#1107) * fix: added form reset on close * feat: added disabled condition for save button * chore: fixed pr comments --------- Co-authored-by: Egor B <[email protected]> * fix: changed default fiat flag value to true (#1106) Co-authored-by: Egor B <[email protected]> * fix: wallet balance assets undefined fix (#1108) Co-authored-by: Egor B <[email protected]> * Fix: zero balance errors fix (#1109) * fix: network zero balances possible fix * fix: wallet 0 balance fix, asset display 0 fix * fix: wallet zero balance fix * fix: network zero balance fix --------- Co-authored-by: Egor B <[email protected]> * fix: removed second shimmer from assets if fiat flag is false (#1110) Co-authored-by: Egor B <[email protected]> --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: egor0798 <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]>

tuul-wq added 3 commits September 20, 2023 07:35

feat: price provider model

d15309a

Merge branch 'dev' into feat/coingeko_model

dc3f4d6

# Conflicts: # src/renderer/app/index.tsx

feat: load assets prices

7e3c192

tuul-wq requested review from Asmadek and egor0798 September 20, 2023 08:10

tuul-wq self-assigned this Sep 20, 2023

tuul-wq commented Sep 20, 2023

View reviewed changes

chore: code style, export events

790c3e4

valentunn reviewed Sep 20, 2023

View reviewed changes

src/renderer/shared/api/price-provider/common/constants.ts Outdated Show resolved Hide resolved

Asmadek approved these changes Sep 20, 2023

View reviewed changes

egor0798 approved these changes Sep 20, 2023

View reviewed changes

tuul-wq changed the base branch from dev to feat/fiat_values September 20, 2023 14:07

feat: tests for models, review fixes

89e3121

tuul-wq merged commit 0b96f2e into feat/fiat_values Sep 21, 2023
4 checks passed

tuul-wq deleted the feat/coingeko_model branch September 21, 2023 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Price provider model #1084

Feat: Price provider model #1084

tuul-wq commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 •

edited

Loading

tuul-wq Sep 20, 2023

tuul-wq commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 •

edited

Loading

Feat: Price provider model #1084

Feat: Price provider model #1084

Conversation

tuul-wq commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 • edited Loading

Current coverage report

Summary

Tests which was executed

tuul-wq Sep 20, 2023

Choose a reason for hiding this comment

tuul-wq commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 • edited Loading

Jest Unit tests results

github-actions bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023 •

edited

Loading