Feat: amount input currency #1083

egor0798 · 2023-09-19T10:58:08Z

No description provided.

github-actions · 2023-09-19T11:02:06Z

Current coverage report

Summary

Lines	Statements	Branches	Functions
	86.29% (422/489)	37.87% (25/66)	76.71% (56/73)

Tests which was executed

Tests	Skipped	Failures	Errors	Time
261	0 💤	0 ❌	0 🔥	3m 29s ⏱️

Coverage by files (87%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	86.29	37.87	76.71	87.47
app/providers/routes	87.5	100	100	100
paths.ts	100	100	100	100
routesConfig.tsx	83.33	100	100	100
entities/asset/ui/AssetIcon	100	100	100	100
AssetIcon.tsx	100	100	100	100
entities/price	83.33	100	100	100
index.ts	83.33	100	100	100
entities/price/lib	66.66	25	50	64.28
constants.ts	100	100	100	100
types.ts	100	100	100	100
useCurrencyRate.ts	30	0	0	37.5	6–12
entities/price/model	100	100	100	100
currency-model.ts	100	100	100	100
price-provider-model.ts	100	100	100	100
features/currency	50	100	100	100
index.ts	50	100	100	100
features/currency/CurrencyForm	50	100	100	100
index.ts	50	100	100	100
features/currency/CurrencyForm/model	96.29	100	90.9	95.65
currency-form.ts	96.29	100	90.9	95.65	14
features/currency/CurrencyForm/ui	36.36	100	0	40
CurrencyForm.tsx	36.36	100	0	40	19–77
pages/Settings	100	100	100	100
index.ts	100	100	100	100
pages/Settings/Currency	71.42	100	0	66.66
Currency.tsx	71.42	100	0	66.66	7–9
pages/Settings/Overview/components/GeneralActions	100	100	100	100
GeneralActions.tsx	100	100	100	100
shared/api/local-storage	100	100	100	100
index.ts	100	100	100	100
shared/api/local-storage/service	81.81	66.66	100	77.77
localStorageService.ts	81.81	66.66	100	77.77	14–16
shared/api/price-provider	100	100	100	100
index.ts	100	100	100	100
shared/api/price-provider/common	100	100	100	100
constants.ts	100	100	100	100
utils.ts	100	100	100	100
shared/api/price-provider/service	100	100	100	100
coingeckoService.ts	100	100	100	100
fiatService.ts	100	100	100	100
shared/core	100	100	100	100
index.ts	100	100	100	100
shared/core/model	100	100	100	100
kernel-model.ts	100	100	100	100
shared/ui	90.32	100	100	90.32
index.ts	90.32	100	100	90.32	63, 69, 77–78, 87, 89, 101, 105, 111
shared/ui/Icon/data	100	100	100	100
arrow.tsx	100	100	100	100
functionals.tsx	100	100	100	100
shared/ui/Inputs/AmountInput	36.66	0	0	39.28
AmountInput.tsx	36.66	0	0	39.28	38–64
shared/ui/Modals/BaseModal	83.33	100	33.33	81.81
BaseModal.tsx	83.33	100	33.33	81.81	36–63
widgets	100	100	100	100
index.ts	100	100	100	100
widgets/CurrencyModal	50	100	100	100
index.ts	50	100	100	100
widgets/CurrencyModal/ui	50	100	0	54.54
CurrencyModal.tsx	50	100	0	54.54	12–18

github-actions · 2023-09-19T11:04:51Z

Jest Unit tests results

Duration: 221.039 seconds

Start:	`2023-09-26 10:17:31.512 UTC`
Finish:	`2023-09-26 10:21:12.551 UTC`
Duration:	`221.039 seconds`

Outcome: Passed | Total Tests: 358 | Passed: 358 | Failed: 0

Total Test Suites:	145
Total Tests:	358
Failed Test Suites:	0
Failed Tests:	0
Passed Test Suites:	145
Passed Tests:	358

# Conflicts: # src/renderer/app/index.tsx

…ech/nova-spektr into feat/currency-settings

…va-spektr into feat/currency-settings

…et/omni-enterprise into feat/input-currency

fix: correct input for priceless asset

…i-enterprise into feat/input-currency

…nput-currency

* Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * feat: added fiat amount for transfer and multisig operations * feat: added fiat values to staking operations --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]>

* Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * Feat: wallet fiat balance balance (#1099) * Feat: Operations parameters fiat amount (#1098) * Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * feat: added fiat amount for transfer and multisig operations * feat: added fiat values to staking operations --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]> * Feat: Fiat update rules (#1096) * feat: fiat update rules * chore: added test * Update src/renderer/entities/price/model/__tests__/price-provider-model.test.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: updated price proveder test * chore: improved priceProvider test --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * Feat/adding dev build (#1103) * Feat: Transaction service refactoring (#1053) * feat: added new transaction service, extrinsic builder and changed transfer florw * feat: removed extra components, changed get fee func * fix: wrap tx for submit step only if account is multisig * feat: implemented new service usage for staking transactions * fix: fix build tx error * chore: fixed tests, removed extrinsic service from public api * fix: signatory error fix * chore: renamed wrappers * chore: renamed operation footer prop and make it optional * Update src/renderer/entities/transaction/lib/extrinsicService.ts Co-authored-by: Yaroslav Grachev <[email protected]> * Update src/renderer/entities/multisig/lib/multisigTx/common/utils.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: fixed pr comments * chore: fixed linter error * chore: removed extra props from transfer form * chore: fix lockfile * chore: fixed confirmation test * fix: fixed xcm transfer fee error * fix: fixed amount error * chore: fixed invalid character error --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * feat: add stage build * fix: remove config separation * fix: change triggers * fix: github triggers * fix: change approach to url management * fix: change trigger and github command * fix: add separate webpack for internal build * fix: eslinter * fix: typo in yamls * Update src/main/factories/create.ts Co-authored-by: Aleksandr Makhnev <[email protected]> --------- Co-authored-by: egor0798 <[email protected]> Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> * Fix: Currency form value reset on close (#1107) * fix: added form reset on close * feat: added disabled condition for save button * chore: fixed pr comments --------- Co-authored-by: Egor B <[email protected]> * fix: changed default fiat flag value to true (#1106) Co-authored-by: Egor B <[email protected]> * fix: wallet balance assets undefined fix (#1108) Co-authored-by: Egor B <[email protected]> * Fix: zero balance errors fix (#1109) * fix: network zero balances possible fix * fix: wallet 0 balance fix, asset display 0 fix * fix: wallet zero balance fix * fix: network zero balance fix --------- Co-authored-by: Egor B <[email protected]> * fix: removed second shimmer from assets if fiat flag is false (#1110) Co-authored-by: Egor B <[email protected]> --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: egor0798 <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]>

Egor B added 3 commits September 15, 2023 16:06

feat: currency select modal

0412aa5

chore: added icon for currency

c16354b

feat: added currency mode to amount input

af0a888

tuul-wq and others added 20 commits September 20, 2023 07:35

feat: price provider model

d15309a

Merge branch 'dev' into feat/coingeko_model

dc3f4d6

# Conflicts: # src/renderer/app/index.tsx

feat: load assets prices

7e3c192

chore: code style, export events

790c3e4

chore: merged coingecko service

3601197

feat: integrated currency modal to currenc settings

036002c

chore: updated crouped select semantics

cdf84b1

chore: fixed General Action test

f8bb7dc

chore: fixed grouped select active state

ef04239

feat: tests for models, review fixes

89e3121

Merge branch 'feat/coingeko_model' into feat/currency-settings

a297522

Merge branch 'feat/currency-settings' of https://github.com/novasamat…

d143269

…ech/nova-spektr into feat/currency-settings

Merge branch 'feat/fiat_values' of https://github.com/novasamatech/no…

011349d

…va-spektr into feat/currency-settings

chore: fixed pr comments

784ea45

chore: added currency form model

d29c01f

chore: merged feat/fiat_value

5d04462

fix: fixed modal reload after submit

652815d

feat: [wip] amount input currency integration

ac94149

chore: removed button disabled condition

45c70b0

feat: amount input with currency integration

7548f1b

egor0798 requested review from Asmadek and tuul-wq September 22, 2023 15:06

egor0798 marked this pull request as ready for review September 22, 2023 15:06

Asmadek and others added 2 commits September 25, 2023 17:02

fix: tests

7b919b8

feat: form model, test

774cc08

tuul-wq and others added 2 commits September 25, 2023 21:31

chore: removed GroupedSelect

c7c4352

Merge branch 'feat/currency-settings' of https://github.com/nova-wall…

ab8eab2

…et/omni-enterprise into feat/input-currency

Asmadek changed the base branch from feat/fiat_values to feat/currency-settings September 26, 2023 07:06

fix: ui

496fe7e

fix: correct input for priceless asset

Base automatically changed from feat/currency-settings to feat/fiat_values September 26, 2023 09:16

Asmadek and others added 4 commits September 26, 2023 14:41

Merge branch 'feat/fiat_values' of https://github.com/nova-wallet/omn…

cea4988

…i-enterprise into feat/input-currency

fix: revert commented code

319155d

chore: merge fiat-branch

1f34134

Merge remote-tracking branch 'origin/feat/input-currency' into feat/i…

dd2182e

…nput-currency

tuul-wq approved these changes Sep 27, 2023

View reviewed changes

Asmadek approved these changes Sep 27, 2023

View reviewed changes

egor0798 merged commit a8d5f3b into feat/fiat_values Sep 27, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: amount input currency #1083

Feat: amount input currency #1083

egor0798 commented Sep 19, 2023

github-actions bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited

Loading

Feat: amount input currency #1083

Feat: amount input currency #1083

Conversation

egor0798 commented Sep 19, 2023

github-actions bot commented Sep 19, 2023 • edited Loading

Current coverage report

Summary

Tests which was executed

github-actions bot commented Sep 19, 2023 • edited Loading

Jest Unit tests results

github-actions bot commented Sep 19, 2023 •

edited

Loading

github-actions bot commented Sep 19, 2023 •

edited

Loading