Feat: Transaction service refactoring #1053

egor0798 · 2023-09-07T10:34:28Z

Resources:

Transaction Service sequnce diagramm

Changes:

Created ExtrinsicService and moved extrinsic creation logic from transaction service
Made transaction service statefull so UI would not be responsible for creating transaction
Removed multisig transaction creation logic from UI
Integrated new transaction service to transfer flow

…ansfer florw

github-actions · 2023-09-07T10:38:35Z

Current coverage report

Summary

Lines	Statements	Branches	Functions
	58.37% (1168/2001)	31.14% (237/761)	40.13% (183/456)

Tests which was executed

Tests	Skipped	Failures	Errors	Time
213	0 💤	0 ❌	0 🔥	3m 10s ⏱️

Coverage by files (59%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	58.37	31.14	40.13	59.98
domain	100	100	100	100
connection.ts	100	100	100	100
entities/asset	100	100	100	100
index.ts	100	100	100	100
entities/multisig/lib/multisigTx/common	16.36	0	0	20.93
utils.ts	16.36	0	0	20.93	26–36, 41–47, 56–72, 80–94, 110–125, 135–139, 160–188
entities/transaction	100	100	100	100
index.ts	100	100	100	100
entities/transaction/lib	28.39	0	10.76	28.02
extrinsicService.ts	25.71	0	10.86	25	23, 40–52, 58–298, 313–354, 363–366, 369, 373, 384–396
transactionService.ts	30.43	0	10.52	30.33	30, 39–41, 54–62, 73–75, 79–81, 89–91, 95–97, 101–104, 108–111, 120–186, 191–193, 197–203, 212
features/operation/init/ui	100	71.42	100	100
OperationFooter.tsx	100	71.42	100	100	85
pages/Staking/Operations/Bond	83.5	54.54	60	85.05
Bond.tsx	83.5	54.54	60	85.05	76–79, 84–85, 133–134, 147, 162–172, 246
pages/Staking/Operations/Bond/InitOperation	71.81	39.02	55.17	79.12
InitOperation.tsx	71.81	39.02	55.17	79.12	93–95, 108–114, 120, 158–161, 173, 177–183, 187–190, 204
pages/Staking/Operations/ChangeValidators	83.9	55.26	60	85.71
ChangeValidators.tsx	83.9	55.26	60	85.71	72–75, 80–81, 125–126, 137, 152–154, 220
pages/Staking/Operations/ChangeValidators/InitOperation	79.77	45.83	73.91	84.93
InitOperation.tsx	79.77	45.83	73.91	84.93	79, 107–109, 113–116, 130–132, 137–139, 145
pages/Staking/Operations/Destination	81.92	51.35	50	83.78
Destination.tsx	81.92	51.35	50	83.78	56–57, 70–73, 78–79, 129–136, 149, 199
pages/Staking/Operations/Destination/InitOperation	78.57	39.28	73.91	83.58
InitOperation.tsx	78.57	39.28	73.91	83.58	77, 99–101, 105–108, 127–129, 134–136, 142
pages/Staking/Operations/Redeem	23.75	6.45	7.14	19.17
Redeem.tsx	23.75	6.45	7.14	19.17	25–196
pages/Staking/Operations/Redeem/InitOperation	74.28	40.74	60.71	78.65
InitOperation.tsx	74.28	40.74	60.71	78.65	106–112, 136–138, 146–159, 169–175, 179–182, 188
pages/Staking/Operations/Restake	84.14	55.88	57.14	86.3
Restake.tsx	84.14	55.88	57.14	86.3	69–72, 77–78, 124–131, 142, 198
pages/Staking/Operations/Restake/InitOperation	69.91	34.28	59.37	75.26
InitOperation.tsx	69.91	34.28	59.37	75.26	99–111, 136–138, 142–145, 156–159, 164–170, 174–177, 189
pages/Staking/Operations/StakeMore	84.14	55.88	57.14	86.3
StakeMore.tsx	84.14	55.88	57.14	86.3	69–72, 77–78, 122, 132–139, 199
pages/Staking/Operations/StakeMore/InitOperation	69.6	38.46	53.57	78.04
InitOperation.tsx	69.6	38.46	53.57	78.04	90–96, 122–124, 128–131, 143, 147–153, 157–160, 172
pages/Staking/Operations/Unstake	79.54	54.28	57.14	82.05
Unstake.tsx	79.54	54.28	57.14	82.05	70–73, 78–79, 125–132, 143–151, 212
pages/Staking/Operations/Unstake/InitOperation	66.94	30.76	55.88	71.28
InitOperation.tsx	66.94	30.76	55.88	71.28	105–117, 122, 142–144, 148–159, 171–174, 179–185, 189–192, 204
pages/Staking/Operations/components/Confirmation	85.29	75	40	87.09
Confirmation.tsx	85.29	75	40	87.09	77–87
shared/api/storage	100	100	100	100
index.ts	100	100	100	100
shared/lib/utils	100	100	100	100
index.ts	100	100	100	100
widgets/SendAssetModal/ui	27.53	10	7.14	23.43
SendAssetModal.tsx	27.53	10	7.14	23.43	32–192
widgets/SendAssetModal/ui/components	12.8	0	0	14.15
TransferForm.tsx	12.8	0	0	14.15	80–439
widgets/SendAssetModal/ui/components/ActionSteps	16.84	0	0	18.28
Confirmation.tsx	45.45	0	0	52.63	39–87
InitOperation.tsx	11.53	0	0	12.63	46–266
Submit.tsx	15.62	0	0	16.39	35–142

github-actions · 2023-09-08T16:02:27Z

Jest Unit tests results

Duration: 228.155 seconds

Start:	`2023-09-21 12:20:16.356 UTC`
Finish:	`2023-09-21 12:24:04.511 UTC`
Duration:	`228.155 seconds`

Outcome: Passed | Total Tests: 339 | Passed: 339 | Failed: 0

Total Test Suites:	141
Total Tests:	339
Failed Test Suites:	0
Failed Tests:	0
Passed Test Suites:	141
Passed Tests:	339

tuul-wq

Code has become much cleaner, nice!

src/renderer/entities/multisig/lib/multisigTx/common/utils.ts

src/renderer/entities/transaction/lib/extrinsicService.ts

src/renderer/entities/transaction/lib/transactionService.ts

src/renderer/pages/Staking/Operations/Bond/Bond.tsx

src/renderer/pages/Staking/Operations/Destination/Destination.tsx

src/renderer/widgets/SendAssetModal/ui/SendAssetModal.tsx

src/renderer/widgets/SendAssetModal/ui/components/ActionSteps/Submit.tsx

Co-authored-by: Yaroslav Grachev <[email protected]>

valentunn

PR doesnt follow discussed architecture and doesnt solve problems that we stated as a DOD for this task

src/renderer/entities/transaction/lib/extrinsicService.ts

src/renderer/pages/Staking/Operations/Bond/Bond.tsx

src/renderer/pages/Staking/Operations/ChangeValidators/ChangeValidators.tsx

valentunn · 2023-09-13T05:04:38Z

Please consider the following DOD for this PR:

No single screen should have if(multisig) logic. Otherwise whole refactoring becomes uselles

src/renderer/pages/Staking/Operations/Bond/Bond.tsx

src/renderer/pages/Staking/Operations/ChangeValidators/ChangeValidators.tsx

src/renderer/entities/multisig/lib/multisigTx/common/utils.ts

* Feat: Transaction service refactoring (#1053) * feat: added new transaction service, extrinsic builder and changed transfer florw * feat: removed extra components, changed get fee func * fix: wrap tx for submit step only if account is multisig * feat: implemented new service usage for staking transactions * fix: fix build tx error * chore: fixed tests, removed extrinsic service from public api * fix: signatory error fix * chore: renamed wrappers * chore: renamed operation footer prop and make it optional * Update src/renderer/entities/transaction/lib/extrinsicService.ts Co-authored-by: Yaroslav Grachev <[email protected]> * Update src/renderer/entities/multisig/lib/multisigTx/common/utils.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: fixed pr comments * chore: fixed linter error * chore: removed extra props from transfer form * chore: fix lockfile * chore: fixed confirmation test * fix: fixed xcm transfer fee error * fix: fixed amount error * chore: fixed invalid character error --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * feat: add stage build * fix: remove config separation * fix: change triggers * fix: github triggers * fix: change approach to url management * fix: change trigger and github command * fix: add separate webpack for internal build * fix: eslinter * fix: typo in yamls * Update src/main/factories/create.ts Co-authored-by: Aleksandr Makhnev <[email protected]> --------- Co-authored-by: egor0798 <[email protected]> Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]>

* Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * Feat: wallet fiat balance balance (#1099) * Feat: Operations parameters fiat amount (#1098) * Feat: Price provider model (#1084) * Feat: Currency settings (#1076) * Feat: fiat balance assets and staking (#1087) * Feat: amount input currency (#1083) * feat: currency select modal * chore: added icon for currency * feat: added currency mode to amount input * feat: price provider model * feat: load assets prices * chore: code style, export events * feat: integrated currency modal to currenc settings * chore: updated crouped select semantics * chore: fixed General Action test * chore: fixed grouped select active state * feat: tests for models, review fixes * chore: fixed pr comments * chore: added currency form model * fix: fixed modal reload after submit * feat: [wip] amount input currency integration * chore: removed button disabled condition * feat: amount input with currency integration * fix: tests * feat: form model, test * chore: removed GroupedSelect * fix: ui fix: correct input for priceless asset * fix: revert commented code --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: asmadek <[email protected]> * feat: added fiat amount for transfer and multisig operations * feat: added fiat values to staking operations --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]> * Feat: Fiat update rules (#1096) * feat: fiat update rules * chore: added test * Update src/renderer/entities/price/model/__tests__/price-provider-model.test.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: updated price proveder test * chore: improved priceProvider test --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * Feat/adding dev build (#1103) * Feat: Transaction service refactoring (#1053) * feat: added new transaction service, extrinsic builder and changed transfer florw * feat: removed extra components, changed get fee func * fix: wrap tx for submit step only if account is multisig * feat: implemented new service usage for staking transactions * fix: fix build tx error * chore: fixed tests, removed extrinsic service from public api * fix: signatory error fix * chore: renamed wrappers * chore: renamed operation footer prop and make it optional * Update src/renderer/entities/transaction/lib/extrinsicService.ts Co-authored-by: Yaroslav Grachev <[email protected]> * Update src/renderer/entities/multisig/lib/multisigTx/common/utils.ts Co-authored-by: Yaroslav Grachev <[email protected]> * chore: fixed pr comments * chore: fixed linter error * chore: removed extra props from transfer form * chore: fix lockfile * chore: fixed confirmation test * fix: fixed xcm transfer fee error * fix: fixed amount error * chore: fixed invalid character error --------- Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> * feat: add stage build * fix: remove config separation * fix: change triggers * fix: github triggers * fix: change approach to url management * fix: change trigger and github command * fix: add separate webpack for internal build * fix: eslinter * fix: typo in yamls * Update src/main/factories/create.ts Co-authored-by: Aleksandr Makhnev <[email protected]> --------- Co-authored-by: egor0798 <[email protected]> Co-authored-by: Egor B <[email protected]> Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> * Fix: Currency form value reset on close (#1107) * fix: added form reset on close * feat: added disabled condition for save button * chore: fixed pr comments --------- Co-authored-by: Egor B <[email protected]> * fix: changed default fiat flag value to true (#1106) Co-authored-by: Egor B <[email protected]> * fix: wallet balance assets undefined fix (#1108) Co-authored-by: Egor B <[email protected]> * Fix: zero balance errors fix (#1109) * fix: network zero balances possible fix * fix: wallet 0 balance fix, asset display 0 fix * fix: wallet zero balance fix * fix: network zero balance fix --------- Co-authored-by: Egor B <[email protected]> * fix: removed second shimmer from assets if fiat flag is false (#1110) Co-authored-by: Egor B <[email protected]> --------- Co-authored-by: Yaroslav Grachev <[email protected]> Co-authored-by: egor0798 <[email protected]> Co-authored-by: Aleksandr Makhnev <[email protected]> Co-authored-by: Egor B <[email protected]>

feat: added new transaction service, extrinsic builder and changed tr…

be92bd6

…ansfer florw

Egor B added 5 commits September 7, 2023 16:18

feat: removed extra components, changed get fee func

8ee5a2d

fix: wrap tx for submit step only if account is multisig

0bbf150

feat: implemented new service usage for staking transactions

72431dc

fix: fix build tx error

8b10bfc

chore: fixed tests, removed extrinsic service from public api

8b0475f

egor0798 marked this pull request as ready for review September 11, 2023 10:35

egor0798 requested review from tuul-wq, Asmadek, ERussel and valentunn September 11, 2023 10:35

egor0798 marked this pull request as draft September 11, 2023 10:47

Egor B added 3 commits September 11, 2023 16:11

fix: signatory error fix

022a790

chore: renamed wrappers

91c916c

chore: renamed operation footer prop and make it optional

139201a

egor0798 marked this pull request as ready for review September 11, 2023 15:29

tuul-wq requested changes Sep 12, 2023

View reviewed changes

egor0798 and others added 2 commits September 12, 2023 21:05

Update src/renderer/entities/transaction/lib/extrinsicService.ts

22c471d

Co-authored-by: Yaroslav Grachev <[email protected]>

Update src/renderer/entities/multisig/lib/multisigTx/common/utils.ts

d003c86

Co-authored-by: Yaroslav Grachev <[email protected]>

valentunn requested changes Sep 13, 2023

View reviewed changes

src/renderer/entities/transaction/lib/extrinsicService.ts Outdated Show resolved Hide resolved

src/renderer/pages/Staking/Operations/Bond/Bond.tsx Show resolved Hide resolved

src/renderer/pages/Staking/Operations/ChangeValidators/ChangeValidators.tsx Show resolved Hide resolved

ERussel reviewed Sep 13, 2023

View reviewed changes

src/renderer/pages/Staking/Operations/Bond/Bond.tsx Outdated Show resolved Hide resolved

ERussel requested changes Sep 13, 2023

View reviewed changes

src/renderer/pages/Staking/Operations/Bond/Bond.tsx Show resolved Hide resolved

src/renderer/pages/Staking/Operations/ChangeValidators/ChangeValidators.tsx Show resolved Hide resolved

Asmadek reviewed Sep 13, 2023

View reviewed changes

src/renderer/entities/multisig/lib/multisigTx/common/utils.ts Outdated Show resolved Hide resolved

Egor B added 2 commits September 13, 2023 17:02

chore: fixed pr comments

f391e7f

chore: fixed merge conflicts

cab3542

egor0798 requested review from ERussel and tuul-wq September 13, 2023 15:14

egor0798 requested review from valentunn and Asmadek September 13, 2023 15:14

chore: fixed linter error

f722f29

tuul-wq approved these changes Sep 14, 2023

View reviewed changes

Asmadek approved these changes Sep 15, 2023

View reviewed changes

Egor B added 4 commits September 19, 2023 16:17

chore: megre conflicts fixed

54532e0

chore: removed extra props from transfer form

6985165

chore: fix lockfile

f0af573

chore: fixed confirmation test

8cab434

ERussel approved these changes Sep 20, 2023

View reviewed changes

valentunn approved these changes Sep 20, 2023

View reviewed changes

Egor B added 3 commits September 20, 2023 14:52

fix: fixed xcm transfer fee error

92929a2

fix: fixed amount error

a076112

chore: fixed invalid character error

221cb92

egor0798 merged commit e30b527 into dev Sep 21, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Transaction service refactoring #1053

Feat: Transaction service refactoring #1053

egor0798 commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 8, 2023 •

edited

Loading

tuul-wq left a comment

valentunn left a comment

valentunn commented Sep 13, 2023

Feat: Transaction service refactoring #1053

Feat: Transaction service refactoring #1053

Conversation

egor0798 commented Sep 7, 2023 • edited Loading

Resources:

Changes:

github-actions bot commented Sep 7, 2023 • edited Loading

Current coverage report

Summary

Tests which was executed

github-actions bot commented Sep 8, 2023 • edited Loading

Jest Unit tests results

tuul-wq left a comment

Choose a reason for hiding this comment

valentunn left a comment

Choose a reason for hiding this comment

valentunn commented Sep 13, 2023

egor0798 commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 7, 2023 •

edited

Loading

github-actions bot commented Sep 8, 2023 •

edited

Loading