Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include number of video views if post is video #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include number of video views if post is video #17

wants to merge 1 commit into from

Conversation

thomax
Copy link

@thomax thomax commented Aug 4, 2016

Do you want videoViews to be camel or snake (video_views)?

@notslang
Copy link
Owner

videoViews sounds good - everything in JS is camelCase, so I try to make sure the JSON API exposes data in that format. Could you add tests for this (using a known video post)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomax @notslang