Skip to content

Commit

Permalink
docs(x/accounts): remove unnecessary TODO comments (cosmos#20081)
Browse files Browse the repository at this point in the history
Signed-off-by: Hwangjae Lee <[email protected]>
  • Loading branch information
meetrick authored Apr 18, 2024
1 parent 5e7aae0 commit c6b8d7d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions x/auth/tx/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ func QueryTx(clientCtx client.Context, hashHexStr string) (*sdk.TxResponse, erro
return nil, err
}

// TODO: this may not always need to be proven
// https://github.com/cosmos/cosmos-sdk/issues/6807
resTx, err := node.Tx(context.Background(), hash, true)
if err != nil {
return nil, err
Expand Down
2 changes: 0 additions & 2 deletions x/auth/tx/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ func (s txServer) GetTx(ctx context.Context, req *txtypes.GetTxRequest) (*txtype
return nil, status.Error(codes.InvalidArgument, "tx hash cannot be empty")
}

// TODO We should also check the proof flag in gRPC header.
// https://github.com/cosmos/cosmos-sdk/issues/7036.
result, err := QueryTx(s.clientCtx, req.Hash)
if err != nil {
if strings.Contains(err.Error(), "not found") {
Expand Down

0 comments on commit c6b8d7d

Please sign in to comment.