Skip to content

Commit

Permalink
Add sleep back temporarily (#99)
Browse files Browse the repository at this point in the history
  • Loading branch information
tizz98 authored Dec 14, 2022
1 parent 036f849 commit 2aace63
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.0.15
current_version = 0.0.16
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)
serialize =
{major}.{minor}.{patch}
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [0.0.16] - 2022-12-14
### Changed
- Added back `asyncio.sleep` before connecting to Noteable (temporarily, until our API fix is deployed to prod)

## [0.0.15] - 2022-12-13
## Changed
- Changed dagster `SolidExecutionContext` to `OpExecutionContext`
Expand Down
2 changes: 1 addition & 1 deletion papermill_origami/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version = "0.0.15"
version = "0.0.16"
5 changes: 5 additions & 0 deletions papermill_origami/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
It enables papermill to run notebooks against Noteable as though it were executing a notebook locally.
"""
import asyncio
import functools
import json
import logging
Expand Down Expand Up @@ -225,6 +226,10 @@ async def execute(self, **kwargs):
else:
ext_logger.info(f"Parameterized notebook available at {parameterized_url}")

# Temporarily sleep for 1s to wait for file to be available to be subscribed to.
# TODO: remove this once Noteable API fix is deployed to prod.
await asyncio.sleep(1)

try:
async with self.setup_kernel(file=self.file, client=self.client, **kwargs):
noteable_nb = nbformat.reads(
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

[tool.poetry]
name = "papermill-origami"
version = "0.0.15"
version = "0.0.16"
description = "The noteable API interface"
authors = ["Matt Seal <[email protected]>"]
maintainers = ["Matt Seal <[email protected]>"]
Expand Down

0 comments on commit 2aace63

Please sign in to comment.