-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
big new image restructure #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
robwittman
previously approved these changes
Jul 11, 2023
robwittman
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the image builds based on:
Current images based on
jupyter/datascience-notebook
are using Python 3.9.x and R 4.2.x, but this will provide the following (all new aside from the ones marked with ✅):To be extra clear, the image builds added in this PR are:
Python 3.9 (
base
)datascience
)noteable
)base-gpu
)datascience
with GPU support)noteable
with GPU support)Python 3.10 (
base
)datascience
)noteable
)base-gpu
)datascience
with GPU support)noteable
with GPU support)(No 3.11
noteable
build since we need to handle some internal dependency resolution)Python 3.11 (
base
)datascience
)base-gpu
)datascience
with GPU support)R 4.3 (
base
)noteable
)Local testing
All images:
piptools compile
without conflictsBase images:
!python --version
within an IPython environment)Datascience images:
Noteable images:
Note: for the
*gpu
builds, I was unable to test with my local kubernetes cluster, but was able todocker run --rm --gpus all local/kernel-python-3.9-base-gpu:dev
(with theconnection_file.json
parts ofrun.sh
commented out) and seenvidia-smi
show the proper output.