Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't replace spaces with periods in data frame conversion #61

Merged
merged 2 commits into from
Oct 25, 2023
Merged

don't replace spaces with periods in data frame conversion #61

merged 2 commits into from
Oct 25, 2023

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Oct 25, 2023 •
edited
Loading

Describe your changes

Fixes an issue where columns that included spaces would be replaced with periods, which breaks the connection between schema and the keys in data and results in empty columns in the DEX/grid view.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I am able to build images locally
  • Has the issue it resolves been discussed with maintainers?

jlrobins
jlrobins previously approved these changes Oct 25, 2023
View reviewed changes
@shouples shouples marked this pull request as ready for review October 25, 2023 22:19
@shouples shouples requested review from a team as code owners October 25, 2023 22:19
@shouples shouples merged commit 73cd1ce into main Oct 25, 2023
10 checks passed
@shouples shouples deleted the R-no-check-names branch October 25, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgbkrk rgbkrk rgbkrk approved these changes

@jlrobins jlrobins jlrobins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shouples @rgbkrk @jlrobins