[NWC] Add get_budget command for per-connection budget limits. #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates the notion of budget from `get_balance` so that permissions can be more appropriately controlled by the wallet. Budgets can be configured by users like how Alby supports, and client apps can query their remaining budget and when it will renew next. Breaking out a separate command for this purpose means that a user can let a client app see their own remaining budget without giving the app access to see their entire wallet balance.
jklein24
force-pushed
the
feat/get_budget
branch
from
9e6a987
to
17cd5be
Compare
rolznz
reviewed
Sep 19, 2024
rolznz
reviewed
Sep 19, 2024
Co-authored-by: Roland <[email protected]>
rolznz
reviewed
Sep 23, 2024
rolznz
approved these changes
Sep 25, 2024
Thanks! We have it implemented internally, but hoping to get that live in the next couple of weeks. If there's no one to grab that ticket in alby hub and it's just in a public repo, I might be open to grabbing that ticket myself too :-) |
davidcaseria
suggested changes
Sep 26, 2024
davidcaseria
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the notion of budget from
get_balanceso that permissions can be more appropriately controlled by the wallet. Budgets can be configured by users like how Alby supports, and client apps can query their remaining budget and when it will renew next.Breaking out a separate command for this purpose means that a user can let a client app see their own remaining budget without giving the app access to see their entire wallet balance.