Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adds a card layout for viewing alumni info in card layout where required & implements on profile highlight and profiles page #12

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SatyaRajAwasth1
Copy link
Contributor

Snapshots:

image

image

</div>
)
}
{Array.isArray(featuredProfiles) && featuredProfiles.length > 0 ? (
Copy link
Contributor

@mukezhz mukezhz Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SatyaRajAwasth1 instead of this type check and length check

Array.isArray(featuredProfiles) && featuredProfiles.length > 0

this single line featuredProfiles?.length will do the job

…where required & implements on profile highlight and profiles page
Copy link
Contributor

@mukezhz mukezhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukezhz mukezhz merged commit 26ff9c0 into noskofficial:develop Oct 14, 2024
@SatyaRajAwasth1
Copy link
Contributor Author

Part of #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants