Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Canal fix #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Canal fix #59

wants to merge 2 commits into from

Conversation

lewismarshall
Copy link
Collaborator

No description provided.

@vaijab
Copy link

vaijab commented Jul 20, 2017

@lewismarshall lewismarshall force-pushed the canal_fix branch 2 times, most recently from 91a442c to c96de3a Compare July 21, 2017 08:31
@lewismarshall
Copy link
Collaborator Author

lewismarshall commented Jul 21, 2017

Unfortunately this is only for namespaced items:

Sysctls which are not namespaced are called node-level and must be set manually by the cluster admin, either by means of the underlying Linux distribution of the nodes (e.g. via /etc/sysctls.conf) or using a DaemonSet with privileged containers.

So I guess we either deploy bash or update the userdata with the "correct value" and test. It all comes down to if smiladon requires 'non-strict' filters or not... @vaijab

@vaijab
Copy link

vaijab commented Jul 21, 2017

or update the userdata with the "correct value"

I prefer this, but for now this PR looks good. I am going to work on hardening host kernel with various MAC modules, etc and plan to stick all of that in userdata, but that's later.

Let's go with your changes first!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants