Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change help dialogue to close #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeepSpawn
Copy link

A click that is not on the help dialogue will cause it to be hidden.
This fixes a small user experience paper-cut.

A click that is not on the help dialogue will cause it be hidden.
@nomeata
Copy link
Owner

nomeata commented Sep 27, 2015

Thanks for your contribution. It fails to pass jshint checking though (see the Travis build log). Can you amend your commit?

@mohrm
Copy link
Collaborator

mohrm commented Oct 4, 2015

@DeepSpawn I cannot reproduce the behaviour you observed (Google Chrome 45.0.2454.101 (64-bit), Ubuntu 15.04) - which browser did you use?

@nomeata
Copy link
Owner

nomeata commented Oct 4, 2015

Oh, sorry @DeepSpawn, I did not see that you amended the pull request, as github does not notify me about this. Next time, also add a comment on the ticket :-)

Also, though, I cannot reproduce it.

@nomeata
Copy link
Owner

nomeata commented Oct 8, 2015

This seems to have stalled. I’m closing it for now, but of course you can re-open it to unstall it.

@nomeata nomeata closed this Oct 8, 2015
@DeepSpawn
Copy link
Author

Hi sorry for the delay in replying, dealing with cabal issues really cooled by enthusiasm for the project.

This pull request is for a minor UX improvement with the information dialogue. Currently you are required to click the information icon or the close icon to dismiss the dialogue. This change means that clicking anywhere that is not on the information dialogue will close the dialogue if it is currently being shown.

@nomeata
Copy link
Owner

nomeata commented Oct 11, 2015

Ah, I then think I misunderstood the original description. Will have a look at it again later.

@nomeata nomeata reopened this Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants