Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding isort for the formatting #99

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

JosePizarro3
Copy link
Collaborator

Adding some more rules and formatting all files to be more plugin-structure compliant.

@JFRudzinski @ndaelman-hu @Bernadette-Mohr this might affect your branches, when rebasing it can get crazy.

Added organizeImports on save on settings.json
@JosePizarro3 JosePizarro3 linked an issue Jul 8, 2024 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9840868774

Details

  • 26 of 43 (60.47%) changed or added relevant lines in 19 files are covered.
  • 15 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.01%) to 78.879%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/atoms_state.py 2 3 66.67%
src/nomad_simulations/schema_packages/model_system.py 2 3 66.67%
src/nomad_simulations/schema_packages/numerical_settings.py 1 2 50.0%
src/nomad_simulations/schema_packages/physical_property.py 2 3 66.67%
src/nomad_simulations/schema_packages/properties/band_gap.py 0 1 0.0%
src/nomad_simulations/schema_packages/properties/band_structure.py 2 3 66.67%
src/nomad_simulations/schema_packages/properties/energies.py 1 2 50.0%
src/nomad_simulations/schema_packages/properties/fermi_surface.py 0 1 0.0%
src/nomad_simulations/schema_packages/properties/forces.py 1 2 50.0%
src/nomad_simulations/schema_packages/properties/hopping_matrix.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/nomad_simulations/schema_packages/properties/fermi_surface.py 1 76.47%
src/nomad_simulations/schema_packages/model_method.py 1 70.94%
src/nomad_simulations/schema_packages/variables.py 1 83.08%
src/nomad_simulations/schema_packages/physical_property.py 1 93.14%
src/nomad_simulations/schema_packages/properties/energies.py 1 75.0%
src/nomad_simulations/schema_packages/properties/band_structure.py 1 80.18%
src/nomad_simulations/schema_packages/properties/forces.py 1 72.73%
src/nomad_simulations/schema_packages/properties/permittivity.py 1 83.33%
src/nomad_simulations/schema_packages/properties/band_gap.py 1 90.2%
src/nomad_simulations/schema_packages/properties/hopping_matrix.py 1 82.76%
Totals Coverage Status
Change from base Build 9836608336: 0.01%
Covered Lines: 1647
Relevant Lines: 2088

💛 - Coveralls

@JosePizarro3 JosePizarro3 merged commit bd2f695 into develop Jul 8, 2024
4 checks passed
@JosePizarro3 JosePizarro3 deleted the 98-adding-isort-for-the-formatting branch July 8, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding isort for the formatting
2 participants