Add unit testing #84
Merged
Add unit testing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added explicitly input for methods in ModelSystem and testing Added testing for _set_system_branch_depth and TODO for the functions in these testings which should be implemented in the datamodel
JosePizarro3
force-pushed
the
9-add-unit-testing
branch
from
83a80ac to
908a34b
Compare
JosePizarro3
force-pushed
the
9-add-unit-testing
branch
from
79af7d0 to
f3b2b43
Compare
|
@JFRudzinski @ndaelman-hu @Bernadette-Mohr Please, be aware of this. No need to do a review of this. Important: I created a script to generate a coverage report with some comprehensive coverage of each of the I think the content of that file is self-explanatory, but I asked Ahmed Ilyas to provide more support on the current Coverage, as the reports in PR requests are pretty cryptic. |
JosePizarro3
force-pushed
the
9-add-unit-testing
branch
from
d9f31ff to
c0e6553
Compare
JosePizarro3
force-pushed
the
9-add-unit-testing
branch
from
77f56b9 to
6fb221b
Compare
JosePizarro3
force-pushed
the
9-add-unit-testing
branch
from
6fb221b to
57be724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing, improving, and adding new testing for all the sections and methods defined so far.
I am also explicitly defining inputs to methods now, to make it more clear when calling them.
Closes #9