Fix minor things #57
Merged
Fix minor things #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to private _check_negative_values in ElectronicBandGap Added get_model_system_ref in Outputs
JosePizarro3
force-pushed
the
fix_minor_things
branch
from
3faf463 to
5f93a09
Compare
Pull Request Test Coverage Report for Build 8753660613Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ndaelman-hu some minor fixes in the files, I will simply merge this.
More importantly, I added a method in Outputs to check if model_system_ref is set, and if not, set it to the unique ModelSystem in Simulation.