Add Outputs base class

[JosePizarro3]

Adding base class for outputs and the unit testing. Testing is a bit empty, but I guess we will see more once we implement other cases.

[JosePizarro3]

(please, disregard the failing pipeline; tests are passing locally)

[ndaelman-hu]

Just some minor points, but I agree with most of the approach.

[ndaelman-hu]

Not sure if I follow the logic here (maybe also add a small pydocs):

This function is used to set is_derived, correct?
If is_derived is already set (i.e. is not None), only then it should trigger.

Moreover, if outputs_ref fully covers is_derived, then you don't need the latter.

[ndaelman-hu]

One more point, I'm going to ask Area D for "write-protected" quantities, i.e. if the value has been set, it can't be updated. This would help make the normalization leaner.

[JosePizarro3]

No, because it might be missing outputs_ref, hence the None return describes the "missing refs" case. I added a better description after you reviewed it, sorry.

[ndaelman-hu]

Okay, but let's run over the possible scenarios:

1. both outputs_ref and is_derived are set, no issue
2. only outputs_ref is set: you can set is_derived = True, but no additional information is conveyed
3. is_derived = True and outputs_ref = None: when would this happen?

[JosePizarro3]

For number 3., maybe some wrong setting of is_derived or some missing outputs_ref when normalizing? In this case, return None is happening

[JosePizarro3]

Just finished some first version, feel free to do another review.

You can also resolve threads when you feel you satisfied with the resolutions.

[coveralls]

Pull Request Test Coverage Report for Build 8523567766

Details

• 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+21.9%) to 88.571%

---

Totals
Change from base Build 8277368865:	21.9%
Covered Lines:	31
Relevant Lines:	35

---

💛 - Coveralls