Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added zenodo doi #135

Merged
merged 2 commits into from
Sep 25, 2024
Merged

added zenodo doi #135

merged 2 commits into from
Sep 25, 2024

Conversation

JFRudzinski
Copy link
Collaborator

@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11034733666

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.309%
Totals Coverage Status
Change from base Build 11027665277: 0.0%
Covered Lines: 2027
Relevant Lines: 2524
💛 - Coveralls

@JosePizarro3
Copy link
Collaborator

And in the How to cite part of the readme :-)

@JFRudzinski
Copy link
Collaborator Author

Can you approve/review @JosePizarro3 ?

JosePizarro3
JosePizarro3 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@JosePizarro3 JosePizarro3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot you bypass the protection?

@JFRudzinski
Copy link
Collaborator Author

Cannot you bypass the protection?

Yes of course, I just wasn't sure how important it was to you. I will do so in the future in cases that it is obviously ok, sorry 😳

@JFRudzinski JFRudzinski merged commit 001ea5e into develop Sep 25, 2024
7 checks passed
@JFRudzinski JFRudzinski deleted the add_zenodo_doi branch September 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosePizarro3 JosePizarro3 JosePizarro3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JFRudzinski @coveralls @JosePizarro3