Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit testing #9

Closed
5 tasks done
JosePizarro3 opened this issue Feb 20, 2024 · 4 comments · Fixed by #15 or #84
Closed
5 tasks done

Adding unit testing #9

JosePizarro3 opened this issue Feb 20, 2024 · 4 comments · Fixed by #15 or #84
Assignees
Labels
testing Testing additions or fixes
Milestone

Comments

@JosePizarro3
Copy link
Collaborator

JosePizarro3 commented Feb 20, 2024

Following @ndaelman-hu and Alvin's suggestion, we will add unit testing for the different classes and functions.

We can follow Alvin's implementation in the test of the simulation workflow schema.

This will be tackled separately, adding unit testing for:

This testing will probably polish the current functionalities, and perhaps add new ones that are missing.

@JosePizarro3 JosePizarro3 added the testing Testing additions or fixes label Feb 20, 2024
@JosePizarro3 JosePizarro3 self-assigned this Feb 20, 2024
@JosePizarro3
Copy link
Collaborator Author

@ndaelman-hu @ladinesa during the dev of unit testing: should we also add testing for the normalize() functions of each class? What if these are empty or just normalize the super level?

@ladinesa
Copy link
Collaborator

@ndaelman-hu @ladinesa during the dev of unit testing: should we also add testing for the normalize() functions of each class? What if these are empty or just normalize the super level?

not sure if i understood it correctly, but we should set up the test such that the normalize function gets executed. We do not need to create a test for each class, we can also just put the test in the parent class if the normalization is simple enough for a single test function.

@JosePizarro3
Copy link
Collaborator Author

not sure if i understood it correctly,

Ok, let me push something this week, and you tell me whether I got the unit testing idea wrong.

@JosePizarro3
Copy link
Collaborator Author

Please @ndaelman-hu check this issue, I left some things opened for you to tackle when you want to implement DFT and BasisSet schemas.

Here, I am satisfied so far with the current coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing additions or fixes
Projects
None yet
2 participants