Skip to content

Commit

Permalink
Add todo
Browse files Browse the repository at this point in the history
  • Loading branch information
@JosePizarro3
JosePizarro3 committed Sep 17, 2024
1 parent 60c30de commit c2f730f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/nomad_simulations/schema_packages/model_system.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ def _check_positions(self, positions_1, positions_2) -> list[int, int]:
return check_positions

def __eq__(self, other: 'Cell') -> bool:
# TODO implement checks on `lattice_vectors` and other quantities to ensure the equality of primitive cells
if not isinstance(other, Cell):
return False

Expand Down

1 comment on commit c2f730f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/nomad_simulations
   __init__.py4250%3–4
   _version.py11282%5–6
src/nomad_simulations/schema_packages
   __init__.py15287%57–59
   atoms_state.py19012932%31–33, 177–197, 215–250, 263–294, 297–315, 362–373, 376–390, 509–524, 536–544, 547–568, 626–633, 645–652, 655–661
   basis_set.py24015336%8–9, 78–79, 115–119, 122–133, 162–165, 168–169, 172–185, 208, 264, 270–271, 275–279, 290–294, 298–302, 306–327, 335, 370–381, 385–397, 417–418, 453–466, 470, 475–476, 513–521, 530, 562–589, 595–600, 603–618, 647–698
   general.py894253%22–25, 69–72, 139, 203, 232–234, 246–304, 307–329
   model_method.py26515243%28–30, 91, 110, 143, 189–192, 195–202, 294–295, 315, 336–355, 371–397, 400–417, 490, 513–556, 559–580, 628–636, 695–697, 723–744, 747–753, 771, 782, 824–831, 869, 888, 968, 1025, 1100, 1214
   model_system.py30020332%43–45, 200–208, 212–218, 301–309, 313–328, 331, 334, 377–394, 397, 411–442, 445–448, 576–603, 621–703, 706–722, 788–792, 795–816, 1021–1059, 1062–1101
   numerical_settings.py25919325%30–32, 54, 165, 193–209, 231–302, 392–412, 428–443, 462–484, 487–514, 579–600, 612–628, 650–680, 698–760, 763–784, 810–812, 827–845, 848–853, 907
   outputs.py1206843%27–28, 171–177, 187–191, 201–205, 208–216, 259–277, 294–327, 330–347, 380, 399
   physical_property.py1024952%38–40, 64–80, 218–220, 241, 253–256, 269, 276, 283–309, 319–321, 324–327, 349–351
   variables.py862571%26–28, 81–88, 91–94, 112–113, 116, 135–136, 139, 163, 185, 207, 229, 251, 274, 290–291, 294
src/nomad_simulations/schema_packages/properties
   band_gap.py513237%26–28, 97–110, 122–144, 147–162
   band_structure.py1237638%27–29, 71–73, 76, 149–150, 162–177, 192–217, 227–236, 250–283, 292–304, 307–326, 339–340, 343, 390–391, 396
   energies.py421857%25–27, 54, 75, 95–97, 100, 117–118, 121, 133–134, 137, 148–149, 152
   fermi_surface.py17759%25–27, 52–55, 58
   forces.py22864%26–28, 55, 75, 94–95, 98
   greens_function.py995247%25–27, 153–155, 167–197, 200–207, 228–229, 232, 253–254, 257, 278–279, 282, 367–373, 383–385, 394–402, 405–421
   hopping_matrix.py291162%25–27, 68–71, 76, 106–109, 112
   permittivity.py483233%25–27, 71–74, 77–80, 89–112, 115–123
   spectral_profile.py26021517%27–29, 57–58, 67–69, 72–78, 98, 112–124, 127–130, 194–195, 217–318, 331–363, 374–386, 400–418, 433–481, 484–520, 539–541, 544, 573–575, 586–611, 616–622
   thermodynamics.py752764%25–27, 53, 74, 90, 99, 108, 119, 128, 155, 165, 175, 190–192, 195, 211, 231–233, 236, 252, 272–274, 277
src/nomad_simulations/schema_packages/utils
   utils.py715128%27–32, 69–79, 86–95, 99–105, 108–113, 117, 121, 138–143, 160–166, 175–177
TOTAL2529154939% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 1 🔥 1.368s ⏱️

Please sign in to comment.