Skip to content

Commit

Permalink
Added todo for testing overwrite_fermi_level once this is under control
Browse files Browse the repository at this point in the history
  • Loading branch information
JosePizarro3 committed Sep 19, 2024
1 parent 1170649 commit a2ff474
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
18 changes: 16 additions & 2 deletions src/nomad_simulations/schema_packages/workflow/dft_plus_tb.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,25 @@ def overwrite_fermi_level(self) -> None:
"""
Overwrites the Fermi level in the TB calculation with the Fermi level from the DFT calculation.
"""
dft_output = self.tasks[0].outputs[-1]
# Check if the `outputs` of the DFT task exist
dft_task = self.tasks[0]
if not dft_task.outputs:
self.link_tasks()

# Check if the `fermi_levels` exist in the DFT output
if not dft_task.m_xpath('outputs[-1].section'):
return None
dft_output = dft_task.outputs[-1].section
if not dft_output.fermi_levels:
return None
fermi_level = dft_output.fermi_levels[-1]

tb_output = self.tasks[1].outputs[-1]
# Assign the Fermi level to the TB output
tb_task = self.tasks[1]
if not tb_task.m_xpath('outputs[-1].section'):
return None
tb_output = tb_task.outputs[-1].section
# ? Does appending like this work creating information in the TB entry?
tb_output.fermi_levels.append(FermiLevel(value=fermi_level.value))

def normalize(self, archive: 'EntryArchive', logger: 'BoundLogger') -> None:
Expand Down Expand Up @@ -183,4 +196,5 @@ def normalize(self, archive: 'EntryArchive', logger: 'BoundLogger') -> None:
self.link_tasks()

# Overwrite the Fermi level in the TB calculation
# ? test if overwritting works
self.overwrite_fermi_level()
2 changes: 2 additions & 0 deletions tests/workflow/test_dft_plus_tb.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,12 @@ def test_overwrite_fermi_level(self):
"""
Test the `overwrite_fermi_level` method of the `DFTPlusTB` section.
"""
# TODO implement once testing in a real case is tested (Wannier90 parser)
assert True

def test_normalize(self):
"""
Test the `normalize` method of the `DFTPlusTB` section.
"""
# TODO implement once testing in a real case is tested (Wannier90 parser)
assert True

1 comment on commit a2ff474

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/nomad_simulations
   __init__.py4250%3–4
   _version.py11282%5–6
src/nomad_simulations/schema_packages
   __init__.py15287%57–59
   atoms_state.py1902189%31–33, 219–222, 246, 301–302, 370–371, 373, 555, 567–568, 629–633, 648–652, 659
   basis_set.py2402888%8–9, 122–133, 172–185, 208, 391–395, 417–418, 462–465, 584, 615, 617
   general.py89891%22–25, 139, 203, 313–314, 324
   model_method.py2657572%28–30, 189–192, 195–202, 315, 336–357, 373–399, 402–419, 773, 784, 826–833, 871, 890, 970, 1027, 1102, 1216
   model_system.py3002392%43–45, 382, 577–580, 627–634, 808–809, 1030–1034, 1040–1041, 1049–1050, 1055, 1078
   numerical_settings.py2596176%30–32, 235, 237–238, 241–244, 248–249, 256–259, 268–271, 275–278, 280–283, 288–291, 297–300, 487–514, 589, 624–627, 651, 654, 699, 701–704, 708, 712, 759, 763–784, 839–840, 907
   outputs.py1201092%27–28, 270–273, 313–316, 341, 343, 380, 399
   physical_property.py102793%38–40, 220, 349–351
   variables.py861286%26–28, 116, 139, 163, 185, 207, 229, 251, 274, 294
src/nomad_simulations/schema_packages/properties
   band_gap.py51590%26–28, 153–154
   band_structure.py1232580%27–29, 250–283, 296, 303, 339–340, 343, 390–391, 396
   energies.py42979%25–27, 54, 75, 100, 121, 137, 152
   fermi_surface.py17476%25–27, 58
   forces.py22673%26–28, 55, 75, 98
   greens_function.py991387%25–27, 228–229, 232, 253–254, 257, 278–279, 282, 418
   hopping_matrix.py29583%25–27, 76, 112
   permittivity.py48883%25–27, 115–123
   spectral_profile.py26012851%27–29, 75–78, 113–116, 217–318, 374–386, 411–414, 434, 439–442, 484–520, 544, 591–594, 610–611, 616–622
   thermodynamics.py752764%25–27, 53, 74, 90, 99, 108, 119, 128, 155, 165, 175, 190–192, 195, 211, 231–233, 236, 252, 272–274, 277
src/nomad_simulations/schema_packages/utils
   utils.py711579%27–32, 86–95, 104–105, 110, 113
src/nomad_simulations/schema_packages/workflow
   base_workflows.py67396%24–25, 191
   dft_plus_tb.py713255%23–24, 108, 111, 151–169, 172–200
   single_point.py44393%26–27, 92
TOTAL271453480% 

Tests Skipped Failures Errors Time
457 0 💤 0 ❌ 0 🔥 4.142s ⏱️

Please sign in to comment.