Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 link to nomad simulations #5

Closed

Conversation

JFRudzinski
Copy link

No description provided.

@JosePizarro3
Copy link

Hi @JFRudzinski , watch out because you are linking your plugin's pull requests to the parser, instead of your @develop or whatever main branch you have in the nomad-parser-h5md plugin.

@JFRudzinski
Copy link
Author

Hi @JFRudzinski , watch out because you are linking your plugin's pull requests to the parser, instead of your @develop or whatever main branch you have in the nomad-parser-h5md plugin.

Thank you!! It's so weird, at some point my PR got mirrored or shifted from my parser plugin repo nomad-coe#2 to here in the parser-plugin-example repo 🤔 😨

@JFRudzinski
Copy link
Author

@JosePizarro3 are you sure that something is wrong? My parser plugin repo seems to be tracking everything accurately: nomad-coe#2 I don't really know what is supposed to happen when you are working on a forked repo, am I supposed to disconnect the fork somehow?

@JosePizarro3
Copy link

@JosePizarro3 are you sure that something is wrong?

Well, we are talking in a pull request in the nomad-parser-plugin-example 😁 @blueraft would you mind helping us and telling us what might have happened?

@blueraft
Copy link
Contributor

Yep, this is in an issue with Github forks. If you make a PR to a forked repo, the default target will be to the original repo (in this case the nomad-parser-example) instead of the fork. You should just close this PR: the other PR looks correct to me.

@JFRudzinski
Copy link
Author

@JosePizarro3 are you sure that something is wrong?

Well, we are talking in a pull request in the nomad-parser-plugin-example 😁 @blueraft would you mind helping us and telling us what might have happened?

haha, indeed, just checking, I very much do not understand 😵

@JFRudzinski
Copy link
Author

forked repo, the default target will be to the original repo (in this case the nomad-parser-example) instead o

Thanks for the quick reply. Is it normal though for the PR to be mirrored? I only created 1 PR in the forked repo not here. It seems to have duplicated it and all my pushed automatically. I checked the remote address and such of my local repo it all seems to correspond to the forked repo.

@JFRudzinski
Copy link
Author

To be clear, I am just asking to make sure it will not happen again, but I guess I can just keep an eye on it

@blueraft
Copy link
Contributor

I think while creating the PR it was automatically targeting the nomad-parser-plugin-repo and you may not have realized that. The two PRs are the same branch from the forked repo so there's nothing wrong on your end there, just a misclick when you initially created the PR probably.

@JFRudzinski
Copy link
Author

was automatically targeting the nomad-parser-plugin-repo and you may not have realized that. The two PRs are the same branch from the forked repo so there's nothing wrong on your end there, just a misclick when you initially created the PR probably.

ok excellent, thanks a lot, I will keep my eyes open next time then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants