Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tutorial for new io package and add more tests #305

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

niyiyu
Copy link
Collaborator

@niyiyu niyiyu commented Mar 15, 2024

This PR implements the following changes:

  • Add more test for the noise module. There are still missing tests for removing response using spectrum, resp, and paz file (poles and zeros), but some are really old functions that obspy seem not supporting any more. Other than that, should b good enough to fix Add unit test coverage to noise_module.py #250.
  • Update the notebooks to use the updated ASDF store, which requires a timestamp for read_bulk.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.77%. Comparing base (bc4b340) to head (eb9ccab).

Files Patch % Lines
src/noisepy/seis/noise_module.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   81.14%   83.77%   +2.63%     
==========================================
  Files           9        9              
  Lines        2052     2052              
  Branches      341      341              
==========================================
+ Hits         1665     1719      +54     
+ Misses        262      212      -50     
+ Partials      125      121       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyiyu niyiyu merged commit 1364820 into main Mar 15, 2024
22 of 23 checks passed
@niyiyu niyiyu deleted the niyiyu/issue250 branch March 15, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test coverage to noise_module.py
1 participant