refactor: update rm_resp from str to enum #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujsinha3
requested review from
mdenolle,
niyiyu,
carlosgjs and
chengxinjiang
as code owners
anujsinha3
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 75.67% 75.77% +0.10%
==========================================
Files 38 38
Lines 4387 4397 +10
Branches 595 597 +2
==========================================
+ Hits 3320 3332 +12
+ Misses 925 923 -2
Partials 142 142 ☔ View full report in Codecov by Sentry. |
anujsinha3
temporarily deployed
to
github-pages
GitHub Actions
Inactive
carlosgjs
approved these changes
Nov 20, 2023
to be covered on: noisepy#250 Co-authored-by: carlosgjs <[email protected]>
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
temporarily deployed
to
github-pages
GitHub Actions
Inactive
kuanfufeng
pushed a commit
that referenced
this pull request
Jan 24, 2024
* refactor: update rm_resp from str to enum * refactor: update tests * added TODO for additional unit tests to be covered on: #250 Co-authored-by: carlosgjs <[email protected]> * added TODO for test updates --------- Co-authored-by: carlosgjs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uw-ssec/codeuw#20