refactor: change freq_norm from string to enum #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujsinha3
requested review from
mdenolle,
niyiyu,
carlosgjs and
chengxinjiang
as code owners
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 62.33% 62.80% +0.46%
==========================================
Files 33 33
Lines 3876 3890 +14
Branches 534 534
==========================================
+ Hits 2416 2443 +27
+ Misses 1336 1323 -13
Partials 124 124
☔ View full report in Codecov by Sentry. |
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
carlosgjs
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Looking great, couple of small corrections. Also, the failure in the notebook is a bit cumbersome to debug, but here's how to find the log:
In this case, the error is:
�[0;31mValidationError�[0m: 1 validation error for ConfigParameters
freq_norm
Input should be a valid string [type=string_type, input_value=<FreqNorm.RMA: 'rma'>, input_type=FreqNorm]
For further information visit https://errors.pydantic.dev/2.3/v/string_type
The ConfigParameter.freq_form field was still declared as str, needs to be updated to FreqNorm.
Also note that you can open the notebook in VS Code and run it directly there and the error should show up.
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
carlosgjs
reviewed
Oct 25, 2023
| @@ -158,12 +166,14 @@ def plot_2d(white_original, white_new): | |||
|
|
|||
|
|
|||
| # Use wrappers since test functions are not supposed to return values | |||
| def test_whiten1d(): | |||
| _, _ = whiten1d() | |||
| @pytest.mark.parametrize("freqNorm", [FreqNorm.PHASE_ONLY, FreqNorm.RMA]) | |||
There was a problem hiding this comment.
very nice! And I see that the code coverage check is now passing.
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@carlosgjs: I am unable to find the logs for the notebook failure. I am getting the below warning-error logs from the build pages log: Also, I am not able to find the artifact log files as well. The picture you posted looks a bit distorted. Can you please clarify once again? |
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
Set navigation_with_keys to False to get rid of the warning. Setting it to True has negative accessibility implications: pydata/pydata-sphinx-theme#1492
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
Set navigation_with_keys to True
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
had a problem deploying
to
github-pages
GitHub Actions
Failure
anujsinha3
temporarily deployed
to
github-pages
GitHub Actions
Inactive
anujsinha3
temporarily deployed
to
github-pages
GitHub Actions
Inactive
carlosgjs
added a commit
that referenced
this pull request
Oct 27, 2023
* refactor: change freq_norm from string to enum * refactor: pre-commit hook format changes * refactor: change freq_norm from string to enum * refactor: correct import * refactor: add parameterized test cases * refactor: fix import * refactor: fix variable type * refactor: fix data sphinx error * refactor: revert the change * refactor: change initialization of freq_norm from string to enum * refactor: change initialization of freq_norm from string to enum * refactor: change initialization of freq_norm from string to enum * refactor: Fix navigation_with_keys warning. Set navigation_with_keys to False to get rid of the warning. Setting it to True has negative accessibility implications: pydata/pydata-sphinx-theme#1492 * refactor: Fix navigation_with_keys warning. Set navigation_with_keys to True * refactor: revert change * refactor: set navigation_with_keys as false to prevent sphinx validation error * refactor: style consistency with \n Co-authored-by: anujsinha3 <[email protected]>
mdenolle
added a commit
that referenced
this pull request
Oct 27, 2023
refactor: change freq_norm from string to enum (#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uw-ssec/codeuw#20