Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better retries for IO, logging #243

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Better retries for IO, logging #243

merged 3 commits into from
Oct 16, 2023

Conversation

carlosgjs
Copy link
Collaborator

  • Fix/refactor retry logic for S3 IO
  • Log which station pairs failed in CC (similar to stacking)
  • Avoid repeatedly checking the S3 bucket for existing pairs when it's empty

@carlosgjs carlosgjs temporarily deployed to github-pages October 16, 2023 18:18 — with GitHub Actions Inactive
@carlosgjs carlosgjs temporarily deployed to github-pages October 16, 2023 18:34 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1fa1daf) 70.56% compared to head (46b8db2) 70.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #243   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files          36       36           
  Lines        4165     4179   +14     
  Branches      576      581    +5     
=======================================
+ Hits         2939     2949   +10     
- Misses       1092     1094    +2     
- Partials      134      136    +2     
Files Coverage Δ
src/noisepy/seis/hierarchicalstores.py 96.64% <100.00%> (-0.20%) ⬇️
src/noisepy/seis/main.py 82.12% <100.00%> (ø)
tests/test_hierarchicalstores.py 100.00% <100.00%> (ø)
src/noisepy/seis/utils.py 90.47% <93.33%> (+0.33%) ⬆️
src/noisepy/seis/correlate.py 76.86% <46.66%> (-1.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosgjs carlosgjs temporarily deployed to github-pages October 16, 2023 23:01 — with GitHub Actions Inactive
@carlosgjs carlosgjs merged commit b55b0f2 into main Oct 16, 2023
@carlosgjs carlosgjs deleted the carlosg/ioretry branch October 16, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants