Allow reading config from S3, refactor main #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgjs
requested review from
mdenolle,
niyiyu and
chengxinjiang
as code owners
carlosgjs
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 70.09% 70.26% +0.16%
==========================================
Files 36 36
Lines 4170 4160 -10
Branches 577 577
==========================================
Hits 2923 2923
+ Misses 1111 1101 -10
Partials 136 136
☔ View full report in Codecov by Sentry. |
carlosgjs
temporarily deployed
to
github-pages
GitHub Actions
Inactive
niyiyu
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #233
Also refactor the running of stack/cc/download in main to removes reduntant/duplicated code. The code to load/save config, error handling and saving of the logs is now in one place.