Changes to store interfaces and implementations #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgjs
had a problem deploying
to
github-pages
GitHub Actions
Failure
carlosgjs
requested review from
mdenolle,
niyiyu and
chengxinjiang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main noisepy/NoisePy#230 +/- ##
==========================================
+ Coverage 68.31% 69.29% +0.97%
==========================================
Files 34 36 +2
Lines 3955 4074 +119
Branches 542 565 +23
==========================================
+ Hits 2702 2823 +121
+ Misses 1120 1118 -2
Partials 133 133
☔ View full report in Codecov by Sentry. |
mdenolle
approved these changes
Oct 4, 2023
|
|
||
| class ASDFStackStore(StackStore): | ||
| def __init__(self, directory: str, mode: str = "a"): | ||
| super().__init__() | ||
| self.datasets = ASDFDirectory(directory, mode, _filename_from_stations, _parse_station_pair_h5file) | ||
|
|
||
| def append(self, src: Station, rec: Station, stacks: List[Stack]): | ||
| # TODO: Do we want to support storing stacks from different timespans in the same store? |
| for stack in stacks: | ||
| self.datasets.add_aux_data((src, rec), stack.parameters, stack.name, stack.component, stack.data) | ||
|
|
||
| def get_station_pairs(self) -> List[Tuple[Station, Station]]: | ||
| return self.datasets.get_keys() | ||
|
|
||
| def read_stacks(self, src: Station, rec: Station) -> List[Stack]: | ||
| def get_timespans(self, src: Station, rec: Station) -> List[DateTimeRange]: | ||
| # TODO: Do we want to support storing stacks from different timespans in the same store? |
There was a problem hiding this comment.
yes eventually, we might want to store all timestamp from a given channel pair into the same store. this would be especially true for the "monitoring" application of this package.
There was a problem hiding this comment.
Sounds good, added issue https://github.com/noisepy/NoisePy/issues/232 to track this
carlosgjs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion: #229
Summary of changes:
read_correlationsandread_stacksare now bothreadcontains()methods