Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: visibility for impl functions #6179

Merged
merged 12 commits into from
Oct 3, 2024
Merged

feat: visibility for impl functions #6179

merged 12 commits into from
Oct 3, 2024

Commits on Sep 30, 2024

  1. feat: visibility for impl functions

    @asterite
    asterite committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    12a1c6f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'master' into ab/visibility-for-impl-functions

    @asterite
    asterite committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    842c915 View commit details
    Browse the repository at this point in the history

  2. Don't error if calling struct private fn from same struct

    @asterite
    asterite committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3223b5b View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @asterite
    asterite committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    50999da View commit details
    Browse the repository at this point in the history

  4. Pass module ID instead of having to clone type

    @asterite
    asterite committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d69e224 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. chore: add new test case

    @TomAFrench
    TomAFrench committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d576a20 View commit details
    Browse the repository at this point in the history

  2. Make sure a module can call private functions of its structs

    @asterite
    asterite committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    385f5a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ab/visibility-for-impl-functions' of github.com:noir-la… 

    …ng/noir into ab/visibility-for-impl-functions
    @asterite
    asterite committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    99e1a50 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @asterite
    asterite committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6eeee56 View commit details
    Browse the repository at this point in the history

  5. Add/remove pub

    @asterite
    asterite committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    29ffae4 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Remove one pub

    @asterite
    asterite committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bdd3447 View commit details
    Browse the repository at this point in the history

  2. Make it pub(crate)

    @asterite
    asterite committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2b6aec2 View commit details
    Browse the repository at this point in the history