Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add assertions for ACVM FunctionInput bit_size #5864

Merged
merged 31 commits into from
Sep 11, 2024
Merged

feat: add assertions for ACVM FunctionInput bit_size #5864

merged 31 commits into from
Sep 11, 2024

Commits on Aug 29, 2024

  1. feat: wip ensuring values and function types match ACVM FunctionInput… 

    … bit_size
    @michaeljklein
    michaeljklein committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4c7cf89 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    fba8b77 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. wip debugging regression_4080, add error for InvalidInputBitSize, thr… 

    …ow error instead of asserting in FunctionInput::constant, convert FieldElement from/to BigUInt to fix distinct-input patch amount modulo, set opcode_location for InvalidInputBitSize
    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    575c2f6 View commit details
    Browse the repository at this point in the history

  2. ensure that 'should_fail_with' in noir tests matches against the erro… 

    …r that the user sees, cargo fmt/clippy
    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0021a68 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    252600f View commit details
    Browse the repository at this point in the history

  4. cargo clippy/fmt

    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d5ebc49 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c38bdf4 View commit details
    Browse the repository at this point in the history

  6. nargo fmt

    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    07f3e69 View commit details
    Browse the repository at this point in the history

  7. patch acvm_js test to use inputs < 2^128 since the FunctionInputs use… 

    …d for the bytecode are of the form: FunctionInput::witness(Witness(_), 128)
    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    adfe490 View commit details
    Browse the repository at this point in the history

  8. another attempt to get the bit size within the expected range

    @michaeljklein
    michaeljklein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6606cf0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    30c7a70 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. update expected bit size for multi-scalar-mul TS tests to maximum

    @michaeljklein
    michaeljklein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    dd645b0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    390c0fa View commit details
    Browse the repository at this point in the history

  3. cargo fmt / yarn lint

    @michaeljklein
    michaeljklein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2c18940 View commit details
    Browse the repository at this point in the history

  4. using only the value + AcirField for InvalidInputBitSize

    @michaeljklein
    michaeljklein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d6ba7c3 View commit details
    Browse the repository at this point in the history

  5. propagate RuntimeError <F> parameter

    @michaeljklein
    michaeljklein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3ae49c4 View commit details
    Browse the repository at this point in the history

  6. responding to review comments

    @michaeljklein
    michaeljklein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9dea841 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7a13c56 View commit details
    Browse the repository at this point in the history

  2. refactoring matches and updating test for overflow

    @michaeljklein
    michaeljklein committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    59a0e13 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c046b73 View commit details
    Browse the repository at this point in the history

  2. removed <F:AcirField> parameter from invalid bit size error, disable … 

    …ACVM bit size checks for bitwise and range ops
    @michaeljklein
    michaeljklein committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    92f936a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7285ef3 View commit details
    Browse the repository at this point in the history

  4. add 'bitsize' to cspell.json, replace usage of InvalidInputBitSize wi… 

    …th UnsupportedIntegerSize in noirc_evaluator
    @michaeljklein
    michaeljklein committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    821b2d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. split UnsupportedIntegerSize into self and InvalidBlackBoxInputBitSize

    @michaeljklein
    michaeljklein committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    52eabc5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into michaeljklein/acvm-check-bitsize

    @michaeljklein
    michaeljklein authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d9c1c7f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. chore: remove unnecessary trait constraints

    @TomAFrench
    TomAFrench committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    010df44 View commit details
    Browse the repository at this point in the history

  2. .

    @TomAFrench
    TomAFrench committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b9d52c7 View commit details
    Browse the repository at this point in the history

  3. .

    @TomAFrench
    TomAFrench committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    404c838 View commit details
    Browse the repository at this point in the history

  4. Update acvm-repo/acvm/src/pwg/mod.rs

    @TomAFrench
    TomAFrench authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e92a509 View commit details
    Browse the repository at this point in the history

  5. chore: remove extra From impls

    @TomAFrench
    TomAFrench committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    136b48c View commit details
    Browse the repository at this point in the history

  6. .

    @TomAFrench
    TomAFrench committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    876d543 View commit details
    Browse the repository at this point in the history