Merge branch 'master' into tf/fix-docs2

* master: (202 commits)
  chore: remove usage of slices in pedersen hash (#6295)
  chore: remove dead function (#6308)
  feat: new formatter (#6300)
  feat: Sync from aztec-packages (#6301)
  fix: Allow array map on empty arrays (#6305)
  fix: Display function name and body when inlining recursion limit hit (#6291)
  feat(interpreter): Comptime derive generators (#6303)
  fix: enforce correctness of decompositions performed at compile time (#6278)
  feat: Warn about private types leaking in public functions and struct fields (#6296)
  chore(docs): refactoring guides and some other nits (#6175)
  fix: Do not warn on unused self in traits (#6298)
  fix: Reject invalid expression with in CLI parser (#6287)
  chore: regression test for #5462 (#6286)
  feat(improve): Remove scan through globals (#6282)
  feat: show LSP diagnostic related information (#6277)
  feat: trait inheritance (#6252)
  feat: optimize reading a workspace's files (#6281)
  fix: prevent compiler panic when popping from empty slices (#6274)
  feat(test): Include the PoseidonHasher in the fuzzing (#6280)
  feat: slightly improve "unexpected token" error message (#6279)
  ...

.aztec-sync-commit

@@ -1 +1 @@
-05cc59fd28b4d0ee89343106e538c0db0e70f52f
+ab0c80d7493e6bdbc58dcd517b248de6ddd6fd67

.github/scripts/cargo-binstall-install.sh

@@ -1,4 +1,9 @@
 #!/usr/bin/env bash
 set -eu
 
-curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
+cd $(dirname "$0")
+
+CARGO_BINSTALL_CHECK=$(./command-check.sh cargo-binstall)
+if [ $CARGO_BINSTALL_CHECK != "true" ]; then
+    curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
+fi

.github/scripts/command-check.sh

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+set -eu
+
+command -v $1 >/dev/null 2>&1 && echo "true" || { echo >&2 "$1 is not installed" && echo "false"; }

.github/scripts/playwright-install.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 set -eu
 
-npx playwright install && npx playwright install-deps
+npx -y playwright@1.42 install --with-deps

.github/workflows/docs-pr.yml

@@ -80,7 +80,7 @@ jobs:
 
       - name: Build docs
         env:
-          MATOMO_ENV: staging # not really a secret, it will show in the footer anyway
+          ENV: staging # not really a secret, it will show in the footer anyway
         run: yarn workspaces foreach -Rpt --from docs run build
 
       - name: Upload artifact

.github/workflows/gates_report_brillig.yml

@@ -74,7 +74,7 @@ jobs:
 
       - name: Compare Brillig bytecode size reports
         id: brillig_bytecode_diff
-        uses: noir-lang/noir-gates-diff@3fb844067b25d1b59727ea600b614503b33503f4
+        uses: noir-lang/noir-gates-diff@d88f7523b013b9edd3f31c5cfddaef87a3fe1b48
         with:
           report: gates_report_brillig.json
           header: |

.github/workflows/test-js-packages.yml

@@ -183,7 +183,7 @@ jobs:
         with:
           name: acvm-js
           path: ./acvm-repo/acvm_js
-      
+
       - name: Set up test environment
         uses: ./.github/actions/setup
 
@@ -230,13 +230,13 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      
+
       - name: Download nargo binary
         uses: actions/download-artifact@v4
         with:
           name: nargo
           path: ./nargo
-      
+
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
@@ -248,7 +248,7 @@ jobs:
         with:
           name: noirc_abi_wasm
           path: ./tooling/noirc_abi_wasm
-      
+
       - name: Set nargo on PATH
         run: |
           nargo_binary="${{ github.workspace }}/nargo/nargo"
@@ -336,13 +336,13 @@ jobs:
         with:
           name: acvm-js
           path: ./acvm-repo/acvm_js
-      
+
       - name: Download noirc_abi package artifact
         uses: actions/download-artifact@v4
         with:
           name: noirc_abi_wasm
           path: ./tooling/noirc_abi_wasm
-      
+
       - name: Set nargo on PATH
         run: |
           nargo_binary="${{ github.workspace }}/nargo/nargo"
@@ -468,7 +468,7 @@ jobs:
         working-directory: ./compiler/integration-tests
         run: |
           yarn test:browser
-  
+
   test-examples:
     name: Example scripts
     runs-on: ubuntu-latest
@@ -509,6 +509,55 @@ jobs:
         working-directory: ./examples/codegen_verifier
         run: ./test.sh
 
+  external-repo-checks:
+    needs: [build-nargo]
+    runs-on: ubuntu-latest
+    # Only run when 'run-external-checks' label is present
+    if: contains(github.event.pull_request.labels.*.name, 'run-external-checks')
+    timeout-minutes: 30
+    strategy:
+      fail-fast: false
+      matrix:
+        project:
+        # Disabled as these are currently failing with many visibility errors
+        - { repo: AztecProtocol/aztec-nr, path: ./ }
+        - { repo: AztecProtocol/aztec-packages, path: ./noir-projects/noir-contracts }
+        # Disabled as aztec-packages requires a setup-step in order to generate a `Nargo.toml`
+        #- { repo: AztecProtocol/aztec-packages, path: ./noir-projects/noir-protocol-circuits }
+        - { repo: zac-williamson/noir-edwards, path: ./, ref: 037e44b2ee8557c51f6aef9bb9d63ea9e32722d1  }
+    name: Check external repo - ${{ matrix.project.repo }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          repository: ${{ matrix.project.repo }}
+          path: test-repo
+          ref: ${{ matrix.project.ref }}
+
+      - name: Download nargo binary
+        uses: actions/download-artifact@v4
+        with:
+          name: nargo
+          path: ./nargo
+
+      - name: Set nargo on PATH
+        run: |
+          nargo_binary="${{ github.workspace }}/nargo/nargo"
+          chmod +x $nargo_binary
+          echo "$(dirname $nargo_binary)" >> $GITHUB_PATH
+          export PATH="$PATH:$(dirname $nargo_binary)"
+          nargo -V
+
+      - name: Remove requirements on compiler version
+        working-directory: ./test-repo
+        run: |
+          # Github actions seems to not expand "**" in globs by default.
+          shopt -s globstar
+          sed -i '/^compiler_version/d' ./**/Nargo.toml
+      - name: Run nargo check
+        working-directory: ./test-repo/${{ matrix.project.path }}
+        run: nargo check
+
   # This is a job which depends on all test jobs and reports the overall status.
   # This allows us to add/remove test jobs without having to update the required workflows.
   tests-end:
@@ -526,7 +575,7 @@ jobs:
       - test-integration-node
       - test-integration-browser
       - test-examples
-    
+
     steps:
         - name: Report overall success
           run: |

.release-please-manifest.json

@@ -1,4 +1,4 @@
 {
-  ".": "0.33.0",
-  "acvm-repo": "0.49.0"
+  ".": "0.35.0",
+  "acvm-repo": "0.51.0"
 }

.tokeignore

@@ -1,9 +1,6 @@
 docs
 scripts
 
-# aztec_macros is explicitly considered OOS for Noir audit
-aztec_macros
-
 # config files
 *.toml
 *.md