Handle resize_to_limit and saver.quality to be compatible with MiniMagick and Vips #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudlevy
reviewed
Jun 30, 2022
lib/kamifusen/processor.rb
Outdated
| url = "#{Kamifusen.keycdn}/#{variant.blob.key}?" | ||
| url += "format=#{transformations[:format]}&" if transformations.has_key? :format | ||
|
|
||
| width = get_resize_width |
There was a problem hiding this comment.
Il vaudrait mieux un lazy load
arnaudlevy
reviewed
Jun 30, 2022
lib/kamifusen/processor.rb
Outdated
| width = get_resize_width | ||
| url += "width=#{width}" unless width.nil? | ||
|
|
||
| quality = get_quality |
arnaudlevy
reviewed
Jun 30, 2022
lib/kamifusen/processor.rb
Outdated
| transformations.dig(:saver, :quality) | ||
| end | ||
|
|
||
| def get_resize_width |
arnaudlevy
reviewed
Jun 30, 2022
lib/kamifusen/processor.rb
Outdated
| @transformations ||= variant.variation.transformations | ||
| end | ||
|
|
||
| def get_quality |
arnaudlevy
reviewed
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications apportées
keycdn_urlprocesseur :variant(resize: "400>")etvariant(quality: 80)au profit devariant(resize_to_limit: [400, nil])etvariant(saver: { quality: 80 })