Node v20.18.1 nsolid v5.5.0 release #226
Open
+14,535
−5,643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs/node#55349 Refs: nodejs/Release#999 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
To save time, the `.github/workflows/doc.yml` workflow runs with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has broken this workflow for Node.js 20 and 18 due to a mismatch in globals. Pin the version of Node.js back to 20. PR-URL: nodejs/node#55755 Fixes: nodejs/node#55754 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]> PR-URL: nodejs/node#54553 Backport-PR-URL: nodejs/node#55213 Fixes: nodejs/node#52298 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Refs: nodejs/node#54553
PR-URL: nodejs/node#55199 Backport-PR-URL: nodejs/node#55265 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Refs: nodejs/node#54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#54792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: nodejs/node#54951 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs/node#54845 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Specifically, `delete Array.prototype.lastIndexOf` immediately crashes the REPL, as does deletion of a few other Array prototype methods. PR-URL: nodejs/node#31457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs/node#54278 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs/node#54401 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: nodejs/node#53303 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs/node#53746 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs/node#54495 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#54386 Reviewed-By: Luigi Pinca <[email protected]>
`AF_INET` has been repeatedly set three times in the code. this should be redundant. removed the last two times. PR-URL: nodejs/node#54939 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#54835 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#54642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#54642 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
This reverts commit c3e1c31baa8f4a59ef49ea0d0429ec55efe2ca81. PR-URL: nodejs/node#54994 Refs: nodejs/node#53957 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Refs: nodejs/node#53382 This test fails on OpenSSL32 because it complains the key being used is too short. It seems to have been missed when the test suite was udpated to have a Makefile to generate key material as the keys are hard coded in the test as opposed to being read in from the fixtures/key directory. Update the test to use keys/certs from the fixtures directory and to remove newlines at the end of the key and cert to retain the inteded test. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#54968 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Refs: nodejs/node#53382 This test fails on OpenSSL32 because it complains the key being used is too short. Adjust the key sizes so that they will pass on OpenSSL32 in addition to other OpenSSL3 versions. Since the keys are not public key related I don't think the increase in key size will be too bad in terms of performance so I've just increased versus guarding for OpenSSL32 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#54972 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#54979 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs/node#54983 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: nodejs/node#54988 Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Raz Luvaton <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
There is no recent trace of failure for this test. Fixes: nodejs/node#47116 PR-URL: nodejs/node#54976 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
PR-URL: nodejs/node#54977 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Environment handles can be cleaned up directly without saving the references in a list and iterate the list. PR-URL: nodejs/node#54993 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Refs: nodejs/node#54968 Refs: nodejs/node#53382 Add additional asserts as suggestd by Richard in: nodejs/node#54968 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs/node#54997 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#55038 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#54585 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Bumps [mozilla-actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.5 to 0.0.6. - [Release notes](https://github.com/mozilla-actions/sccache-action/releases) - [Commits](Mozilla-Actions/sccache-action@89e9040...9e326eb) --- updated-dependencies: - dependency-name: mozilla-actions/sccache-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: nodejs/node#55225 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Specify the initial default value of `autoSelectFamily` in description of `net.setDefaultAutoSelectFamily()` as specified in description of `net.getDefaultAutoSelectFamily()`. PR-URL: nodejs/node#55245 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
PR-URL: nodejs/node#55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: nodejs/node#55304 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs/node#55172 Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs/node#55284 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#55300 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs/node#55144 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Syntax detection has been unflagged so it's no longer meaningful to toggle the detection based on CLI flags. It was also previously benchmarking cached module imports which isn't very meaningful for subsequent loads. This patch updates the benchmark to toggle the detection based on the presence of type field in the package.json, and generates fixtures to benchmark fresh module loads. PR-URL: nodejs/node#55238 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Fixes: nodejs/node#55053 PR-URL: nodejs/node#55331 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This reverts commit 7ddbfe8. PR-URL: nodejs/node#55344 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#55344 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs/node#55329 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
This should make easier to read on benchmark/compare and when generating graphs PR-URL: nodejs/node#55254 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Use rclone to upload assets to Cloudflare as it is more reliable. Refs: nodejs/build#3508 PR-URL: nodejs/node#55617 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: nodejs/node#54853 Backport-PR-URL: nodejs/node#55264 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#55318 Backport-PR-URL: nodejs/node#55264 Reviewed-By: Michaël Zasso <[email protected]>
Notable changes: doc: * add abmusse to collaborators (Abdirahim Musse) nodejs/node#55086 PR-URL: nodejs/node#55879
2024-11-20 Node.js v20.18.1 Iron (LTS) Release Git-EVTag-v0-SHA512: 93ff8a38e6c72581e6bb28fff8992be5027dd92ea1df200bf807a579a07d41aa724b70a05ce2fad887f3202be720ebda0472298bab7e04c4732e218c327d7ee2
Added a `EnvInst::CloseUvHandles()` to be used now that `Environment::RegisterHandleCleanup()` doesn't exist anymore.
juanarbol
added a commit
that referenced
this pull request
Nov 22, 2024
juanarbol
force-pushed
the
node-v20.18.1-nsolid-v5.5.0-release
branch
from
64cb94e
to
97c6f87
Compare
PR-URL: #229 Reviewed-by: Juan José Arboleda <[email protected]>
juanarbol
added a commit
that referenced
this pull request
Nov 22, 2024
juanarbol
force-pushed
the
node-v20.18.1-nsolid-v5.5.0-release
branch
from
97c6f87
to
3d3fa7c
Compare
juanarbol
force-pushed
the
node-v20.18.1-nsolid-v5.5.0-release
branch
from
3d3fa7c
to
c3602e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-11-22, Version 20.18.1-nsolid-v5.5.0 'Iron'
Commits
baed8d4021] - deps: avoid overflow when calculating timeDeltas (Santiago Gimeno) nodesource/nsolid#2296fafa1d38c] - src: close EnvInst handles after v20.18.1 mergee95835387c] - agents: fix synchronized code in GrpcAgent (Santiago Gimeno) nodesource/nsolid#22239a6fb92d8] - agents: fix ExitEvent condition handling (Santiago Gimeno) nodesource/nsolid#2229a844ef45e] - deps: escape funtionName in CPU Profiles (Santiago Gimeno) nodesource/nsolid#17904a1aa08f4] - deps: fix Windows 11 SDK compilation (Santiago Gimeno) nodesource/nsolid#222fef5776e1b] - deps: update grpc to 1.67.1 (Santiago Gimeno) nodesource/nsolid#2201eb24c02fb] - deps: update libsodium to 1.0.20 (Santiago Gimeno) nodesource/nsolid#219693bb4f31e] - deps: update to libcurl 8.11.0 (Santiago Gimeno) nodesource/nsolid#217a7a6f2aa16] - deps,tools: add missing grpc compiler folder (Santiago Gimeno) nodesource/nsolid#2236fafa1d38c] - src: close EnvInst handles after v20.18.1 merge (Santiago Gimeno)e78ded9d9d] - test: unflake test-nsolid asset tests (Santiago Gimeno) nodesource/nsolid#22252fbfb15b9] - tools: fix CURRENT_VERSION calculation (Santiago Gimeno) nodesource/nsolid#218