Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading mongoose version to 8.x #238

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Upgrading mongoose version to 8.x #238

merged 7 commits into from
Sep 4, 2024

Conversation

pacostas
Copy link
Member

@pacostas pacostas commented Sep 3, 2024 •
edited
Loading

This PR :

  • converts mongoose callbacks to async await.
  • adds an extra variable to disable replicaSet in local setup
  • Adds node version 22 to test against
  • upgrading actions to v4 (as there are warnings)
  • Commenting out pkgjs/support step on github workflows

@coveralls
Copy link

coveralls commented Sep 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10683395574

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+35.1%) to 35.088%
Totals Coverage Status
Change from base Build 10417327706: 35.1%
Covered Lines: 20
Relevant Lines: 51
💛 - Coveralls

@pacostas
Copy link
Member Author

pacostas commented Sep 3, 2024

@mhdawson @lholmquist

I've disable the npx @pkgjs/support show step as it breaks due to unsopported node engine.

Opened Issue pkgjs/support#52

mhdawson
mhdawson approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas merged commit 8006f7b into nodeshift:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lholmquist lholmquist lholmquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacostas @coveralls @lholmquist @mhdawson